feat(sharing): Deploy using testnets deployer #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
approved these changes
May 19, 2025
Comment on lines
105
to
+107
| - name: Verify contracts | ||
| working-directory: packages/sharing-smart-contract | ||
| run: echo "Verify contracts" # npm run verify:ignition -- <deploymentId> | ||
| run: echo "TODO" # npm run verify:ignition -- $DEPLOYMENT_ID |
Contributor
There was a problem hiding this comment.
This step could be removed to be merged with the deployment step
Contributor
There was a problem hiding this comment.
npm run deploy -- --network ${{ inputs.network }} --verify
Member
Author
There was a problem hiding this comment.
Yes we can discuss that in the next steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment job: https://github.com/iExecBlockchainComputing/dataprotector-sdk/actions/runs/15116808225