Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

No description provided.

@Le-Caignec Le-Caignec self-assigned this May 21, 2025
@Le-Caignec Le-Caignec marked this pull request as ready for review May 22, 2025 11:45
@PierreJeanjacquot PierreJeanjacquot self-requested a review May 22, 2025 11:56
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreJeanjacquot PierreJeanjacquot self-requested a review May 22, 2025 13:04
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom start block seems to be missing; we need it to start indexing at the fork level

Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom start block injection in the deployer is needed
For the sdk test purpose, we need to configure the subgraph deployer to start indexing from the BELLECOUR_FORK_BLOCK value to avoid a full subgraph resync which is not possible in the tests timeframe.

…te networks.json handling

- Added START_BLOCK to .env.template and updated env.ts to validate it as a non-negative integer.
- Enhanced prepare-test-env.ts to fetch the current block number and update networks.json with the specified or current block number.
- Updated package.json scripts to include dotenv for environment variable management.
- Added ethers and tsx as dev dependencies for improved testing and environment preparation.
- Created tsconfig.json for TypeScript configuration.
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove useless complexity from packages/subgraph/test-stack/prepare-test-env.ts

@Le-Caignec Le-Caignec changed the title Fix/fix scripts subgraph package Fix: scripts subgraph package May 26, 2025
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you :)

@Le-Caignec Le-Caignec merged commit ceaddaa into develop May 26, 2025
15 of 16 checks passed
@Le-Caignec Le-Caignec deleted the fix/fix-scripts-subgraph-package branch May 26, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants