-
Notifications
You must be signed in to change notification settings - Fork 10
Fix: scripts subgraph package #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…proved functionality
…t in the build context
- use a manifest template - fix bad env substitution
chore(subgraph): add .nvmrc file with Node.js version 20.18
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom start block seems to be missing; we need it to start indexing at the fork level
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom start block injection in the deployer is needed
For the sdk test purpose, we need to configure the subgraph deployer to start indexing from the BELLECOUR_FORK_BLOCK value to avoid a full subgraph resync which is not possible in the tests timeframe.
…te networks.json handling - Added START_BLOCK to .env.template and updated env.ts to validate it as a non-negative integer. - Enhanced prepare-test-env.ts to fetch the current block number and update networks.json with the specified or current block number. - Updated package.json scripts to include dotenv for environment variable management. - Added ethers and tsx as dev dependencies for improved testing and environment preparation. - Created tsconfig.json for TypeScript configuration.
…deploy script path
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove useless complexity from packages/subgraph/test-stack/prepare-test-env.ts
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you :)
No description provided.