-
Notifications
You must be signed in to change notification settings - Fork 10
chore(sdk): bump v2.0.0-beta.16 #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Pierre Jeanjacquot <[email protected]>
Co-authored-by: Robin Le Caignec <[email protected]>
Co-authored-by: Le-Caignec <[email protected]> Co-authored-by: Robin Le Caignec <[email protected]>
…ge (#407) Co-authored-by: abbes benayache <[email protected]>
for app & dataset & workerpool
… appMaxPrice & workerpoolMaxPrice as parameters
Co-authored-by: Zied <[email protected]>
* feat: add environment configuration schema with Zod validation * refactor: update build process to use graph-cli v0.96.0 * refactor: remove deprecated generateManifest approach * refactor: consolidate build scripts and dependencies * fix: update local graph commands to include network name for consistency
…fig and matched deal (#438)
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Pierre Jeanjacquot <[email protected]>
Co-authored-by: pjt <[email protected]>
c594461 to
d50cc15
Compare
d50cc15 to
00a9d82
Compare
| @@ -202,10 +214,15 @@ | |||
| address _subscriberAddress | |||
| ) public view returns (uint48) { | |||
| return collectionDetails[_collectionTokenId].subscribers[_subscriberAddress]; | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| address _subscriberAddress | ||
| ) public view returns (uint48) { | ||
| return collectionDetails[_collectionTokenId].subscribers[_subscriberAddress]; | ||
| } |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| bytes calldata _extraData | ||
| ) public returns (bool) { | ||
| if (msg.sender != address(POCO_DELEGATE)) { | ||
| revert OnlyPocoCallerAuthorized(msg.sender); |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| _extraData[4:], | ||
| (address, RentingParams) | ||
| ); | ||
| _rentProtectedData(protectedData, _sender, rentingParams); |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| @@ -402,10 +431,13 @@ | |||
| _protectedDataDetails.rentingParams.price | |||
| ); | |||
| emit NewRental(_protectedDataDetails.collection, _protectedData, spender, endDate); | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| _protectedDataDetails.rentingParams.price | ||
| ); | ||
| emit NewRental(_protectedDataDetails.collection, _protectedData, spender, endDate); | ||
| } |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| @@ -433,17 +465,26 @@ | |||
| **************************************************************************/ | |||
| /// @inheritdoc ISale | |||
| function buyProtectedData(address _protectedData, address _to, uint72 _price) public { | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| **************************************************************************/ | ||
| /// @inheritdoc ISale | ||
| function buyProtectedData(address _protectedData, address _to, uint72 _price) public { | ||
| return _buyProtectedData(_protectedData, msg.sender, _to, _price); |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| // ---------------------ManageOrders state---------------------------------- | ||
| IExecPocoDelegate internal immutable POCO_DELEGATE; | ||
| bytes32 internal constant TAG = 0x0000000000000000000000000000000000000000000000000000000000000003; // [tee,scone] | ||
| IPoCo internal immutable POCO_DELEGATE; |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| AddOnlyAppWhitelistRegistry public immutable APP_WHITELIST_REGISTRY = | ||
| AddOnlyAppWhitelistRegistry(msg.sender); |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
SeddikBellamine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.