Skip to content

Conversation

@PierreJeanjacquot
Copy link
Member

No description provided.

SeddikBellamine and others added 30 commits March 25, 2025 10:59
Co-authored-by: Le-Caignec <[email protected]>
Co-authored-by: Robin Le Caignec <[email protected]>
for app & dataset & workerpool
… appMaxPrice & workerpoolMaxPrice as parameters
Le-Caignec and others added 20 commits April 29, 2025 17:57
* feat: add environment configuration schema with Zod validation

* refactor: update build process to use graph-cli v0.96.0 
* refactor: remove deprecated generateManifest approach
* refactor: consolidate build scripts and dependencies

* fix: update local graph commands to include network name for consistency
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Pierre Jeanjacquot <[email protected]>
@PierreJeanjacquot PierreJeanjacquot force-pushed the release/sdk-v2.0.0-beta.16 branch from c594461 to d50cc15 Compare June 16, 2025 14:19
@PierreJeanjacquot PierreJeanjacquot force-pushed the release/sdk-v2.0.0-beta.16 branch from d50cc15 to 00a9d82 Compare June 16, 2025 14:21
@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review June 16, 2025 14:25
@@ -202,10 +214,15 @@
address _subscriberAddress
) public view returns (uint48) {
return collectionDetails[_collectionTokenId].subscribers[_subscriberAddress];

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

address _subscriberAddress
) public view returns (uint48) {
return collectionDetails[_collectionTokenId].subscribers[_subscriberAddress];
}

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

bytes calldata _extraData
) public returns (bool) {
if (msg.sender != address(POCO_DELEGATE)) {
revert OnlyPocoCallerAuthorized(msg.sender);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

_extraData[4:],
(address, RentingParams)
);
_rentProtectedData(protectedData, _sender, rentingParams);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

@@ -402,10 +431,13 @@
_protectedDataDetails.rentingParams.price
);
emit NewRental(_protectedDataDetails.collection, _protectedData, spender, endDate);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

_protectedDataDetails.rentingParams.price
);
emit NewRental(_protectedDataDetails.collection, _protectedData, spender, endDate);
}

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

@@ -433,17 +465,26 @@
**************************************************************************/
/// @inheritdoc ISale
function buyProtectedData(address _protectedData, address _to, uint72 _price) public {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

**************************************************************************/
/// @inheritdoc ISale
function buyProtectedData(address _protectedData, address _to, uint72 _price) public {
return _buyProtectedData(_protectedData, msg.sender, _to, _price);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

// ---------------------ManageOrders state----------------------------------
IExecPocoDelegate internal immutable POCO_DELEGATE;
bytes32 internal constant TAG = 0x0000000000000000000000000000000000000000000000000000000000000003; // [tee,scone]
IPoCo internal immutable POCO_DELEGATE;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable ManageOrders.POCO_DELEGATE is not in mixedCase
Comment on lines +25 to +26
AddOnlyAppWhitelistRegistry public immutable APP_WHITELIST_REGISTRY =
AddOnlyAppWhitelistRegistry(msg.sender);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable AddOnlyAppWhitelist.APP_WHITELIST_REGISTRY is not in mixedCase
Copy link
Contributor

@SeddikBellamine SeddikBellamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreJeanjacquot PierreJeanjacquot merged commit 5bbb17d into main Jun 16, 2025
12 of 15 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the release/sdk-v2.0.0-beta.16 branch June 16, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants