Skip to content

Conversation

@PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented Jun 25, 2025

  • Added allowExperimentalNetworks option (default false) to IExecDataProtector's constructor and getWeb3Provider(). When allowExperimentalNetworks: true providers connected to experimental networks can be used
  • Added arbitrum-sepolia-testnet as an experimental network

@PierreJeanjacquot PierreJeanjacquot force-pushed the feat/experimental-networks branch from 18f673d to b1a9801 Compare July 1, 2025 08:09
@PierreJeanjacquot PierreJeanjacquot force-pushed the feat/experimental-networks branch from b1a9801 to df74a15 Compare July 1, 2025 12:42
@PierreJeanjacquot PierreJeanjacquot changed the title Feat/experimental networks feat(sdk): add experimental networks Jul 1, 2025
@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review July 7, 2025 08:24
Copy link
Contributor

@SeddikBellamine SeddikBellamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM! the constructor tests are great but the other tests are passing because we run them on bellecour, shouldn't we consider in the future adding a test stack for the network that has been added and execute tests on all the existing networks configurations with wallets that have fake funds in them to simulate real transactions ?
it's there that we might find some new kind or errors related to the chain and txs fees

@PierreJeanjacquot
Copy link
Member Author

Good job, LGTM! the constructor tests are great but the other tests are passing because we run them on bellecour, shouldn't we consider in the future adding a test stack for the network that has been added and execute tests on all the existing networks configurations with wallets that have fake funds in them to simulate real transactions ? it's there that we might find some new kind or errors related to the chain and txs fees

arbitrum-sepolia-testnet is experimental and may be removed anytime soon, so I don't think it is worth it on this network, but we may want to reconsider the question for non-experimental networks.

@PierreJeanjacquot PierreJeanjacquot merged commit 62da0dc into main Jul 7, 2025
10 of 11 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the feat/experimental-networks branch July 7, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants