Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jul 24, 2025

No description provided.

@Le-Caignec Le-Caignec changed the title refactor: consolidate CI workflows and update environment variables f… fix/dataProtector sharing fix ci Jul 24, 2025
Base automatically changed from fix/dataProtector-fix-ci to main July 25, 2025 08:24
@gfournierPro gfournierPro requested review from Copilot and zguesmi July 25, 2025 10:03
@gfournierPro gfournierPro self-assigned this Jul 25, 2025
@gfournierPro gfournierPro marked this pull request as ready for review July 25, 2025 10:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI issues and adds support for Arbitrum mainnet deployment in the sharing smart contract package. The changes standardize deployment configuration, update environment variable names, and modernize the CI setup.

Key Changes:

  • Refactored deployment system to use Hardhat Ignition instead of custom scripts
  • Updated Node.js version from 18 to 20 throughout the codebase
  • Standardized environment variable naming and added support for flexible contract verification

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/sharing-smart-contract/package.json Updates deploy script to use Hardhat Ignition with create2 strategy
packages/sharing-smart-contract/hardhat.config.cjs Adds Arbitrum mainnet config and standardizes environment variables
packages/sharing-smart-contract/config/env.cjs Renames PRIVATE_KEY to DEPLOYER_PRIVATE_KEY and adds verification config
packages/sharing-smart-contract/CHANGELOG.md Documents the CI fixes and Arbitrum mainnet support
packages/sharing-smart-contract/.nvmrc Updates Node.js version from 18 to 20
packages/sharing-smart-contract/.env.template Updates template with new environment variable names
.github/workflows/sharing-smart-contracts-ci.yml Consolidates CI workflow and updates to Node.js 20
.github/workflows/sharing-smart-contract-deploy.yml Major refactor of deployment workflow with improved validation
.github/workflows/sharing-smart-contract-ci.yml Removes redundant CI workflow file

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor Author

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment ID Issue:

Could you rename the existing committed deployment-id folder chain-421614, or just remove it?

Code Modification :

Could you modify this line in the deployment script: const proxyAdminOwner = m.getAccount(0); to use the ADMIN_PRIVATE_KEY environment variable instead? According to our workflow, the deployer should not be the admin.

@gfournierPro gfournierPro force-pushed the fix/dataProtector-sharing-fix-ci branch from 7405d62 to fc617a9 Compare July 25, 2025 14:00
@Le-Caignec Le-Caignec merged commit bab0e44 into main Jul 25, 2025
4 checks passed
@Le-Caignec Le-Caignec deleted the fix/dataProtector-sharing-fix-ci branch July 25, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants