fix: add missing ipfsNodeURL parameter in IExecDataProtectorModule#533
Closed
abbesBenayache wants to merge 1 commit intomainfrom
Closed
fix: add missing ipfsNodeURL parameter in IExecDataProtectorModule#533abbesBenayache wants to merge 1 commit intomainfrom
abbesBenayache wants to merge 1 commit intomainfrom
Conversation
This fix ensures that custom IPFS node URLs (e.g., local IPFS for testing) are properly passed to the internal IExec instance. Without this fix, tests using local IPFS (like Docker Compose setups) fail with connection timeouts to production IPFS nodes because the IExec instance was using default chain IPFS URLs instead of the custom configured ones. Changes: - Added ipfsNodeURL: ipfsNode to the IExec constructor options - This parameter was already extracted from config but never used - ipfsGatewayURL was already being passed, making this a missing piece Impact: - ✅ Tests with local IPFS now work correctly - ✅ Custom IPFS configurations are properly respected - ✅ No regression for production (spread operator still allows override) - ✅ Consistent with ipfsGatewayURL handling
Member
|
Current version of this option will likely be added in bulk processing (PR still in draft iExecBlockchainComputing/iexec-sdk#463) |
Member
|
@abbesBenayache fix reported in bulk processing PR c4a9357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ensures that custom IPFS node URLs (e.g., local IPFS for testing) are properly passed to the internal IExec instance.
Without this fix, tests using local IPFS (like Docker Compose setups) fail with connection timeouts to production IPFS nodes because the IExec instance was using default chain IPFS URLs instead of the custom configured ones.
Changes:
Impact: