Skip to content

Conversation

@ErwanDecoster
Copy link
Member

No description provided.

@ErwanDecoster ErwanDecoster self-assigned this May 9, 2025
@ErwanDecoster ErwanDecoster changed the title Feature/add main pages feat: add main pages May 9, 2025
…directly into AppsRoute with refetch indicator
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bug on the pagination and filename casing issue.
Maybe an optimisation is possible on next pages detection to discuss (now or later).

Plus I have a few TS errors that prevent the production build to succeed, it may be worth addressing these ASAP to avoid later stress for deployment.

@ErwanDecoster
Copy link
Member Author

With the latest commits, I introduced the variable hasPastError, which allows me to maintain the error state between refreshes.

Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still npm run build is failing

@ErwanDecoster ErwanDecoster merged commit d8fcb93 into main May 21, 2025
2 checks passed
@ErwanDecoster ErwanDecoster deleted the feature/add-main-pages branch May 21, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants