feat(sconify): add sconify workflow #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sconify/README.md
Outdated
|
|
||
| jobs: | ||
| sconify: | ||
| uses: iExecBlockchainComputing/github-actions-workflows/.github/workflows/[email protected] |
Member
Author
There was a problem hiding this comment.
NB: sconify-v1.0.0 tag does not exist yet, use feat/sconify instead to test from this branch
SeddikBellamine
left a comment
SeddikBellamine
left a comment
There was a problem hiding this comment.
Left some comments and a question
.github/workflows/sconify.yml
Outdated
Comment on lines
126
to
142
| docker run \ | ||
| --rm \ | ||
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| registry.scontain.com/scone-production/iexec-sconify-image:${{ inputs.sconify-version }} \ | ||
| sconify_iexec \ | ||
| --from=$FROM_IMAGE \ | ||
| --to=$DEBUG_IMAGE \ | ||
| --binary-fs \ | ||
| --fs-dir=${{ inputs.fs-dir }} \ | ||
| --host-path=/etc/hosts \ | ||
| --host-path=/etc/resolv.conf \ | ||
| --binary=${{ inputs.binary }} \ | ||
| --heap=${{ inputs.heap }} \ | ||
| --dlopen=${{ inputs.dlopen }} \ | ||
| --no-color \ | ||
| --verbose \ | ||
| --command="${{ inputs.command }}" |
There was a problem hiding this comment.
shouldn't we use a script that would be more cleaner for code readability ?
Suggested change
| docker run \ | |
| --rm \ | |
| -v /var/run/docker.sock:/var/run/docker.sock \ | |
| registry.scontain.com/scone-production/iexec-sconify-image:${{ inputs.sconify-version }} \ | |
| sconify_iexec \ | |
| --from=$FROM_IMAGE \ | |
| --to=$DEBUG_IMAGE \ | |
| --binary-fs \ | |
| --fs-dir=${{ inputs.fs-dir }} \ | |
| --host-path=/etc/hosts \ | |
| --host-path=/etc/resolv.conf \ | |
| --binary=${{ inputs.binary }} \ | |
| --heap=${{ inputs.heap }} \ | |
| --dlopen=${{ inputs.dlopen }} \ | |
| --no-color \ | |
| --verbose \ | |
| --command="${{ inputs.command }}" | |
| ./sconify.sh arg1 arg2 arg3 |
Member
Author
There was a problem hiding this comment.
We need to pass a lot of input to the command. IMO, moving the command in a script would add extra complexity and no better readability.
Member
Author
There was a problem hiding this comment.
the command is now prepared in a previous step (still in this file)
PierreJeanjacquot
force-pushed
the
feat/sconify
branch
from
b7d3f85 to
f916901
Compare
PierreJeanjacquot
force-pushed
the
feat/sconify
branch
from
f23cb64 to
d0bdc82
Compare
thewhitewizard
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reusable GitHub Actions workflow automates the process of sconifying a Docker image. It is configurable via inputs for the Sconification options and secrets for docker registries credentials and production enclave signing key.
tests: