Skip to content

refactor: remove redundant comments in transaction proposal workflow #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Le-Caignec merged 1 commit into from
Oct 7, 2025
Merged

refactor: remove redundant comments in transaction proposal workflow #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions propose-safe-multisig-tx/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { privateKeyToAccount } from "viem/accounts";
import { env } from "./env.js";

async function run() {
// Environment variables are already validated and parsed
const {
RPC_URL: rpcUrl,
SAFE_ADDRESS: safeAddress,
Expand All @@ -22,23 +21,19 @@ async function run() {
core.info(`📍 Safe Address: ${safeAddress}`);
core.info(`🎯 Target Address: ${transactionTo}`);

// Initialize wallet
const account = privateKeyToAccount(safeProposerPrivateKey as `0x${string}`);
core.info(`🔑 Proposer Address: ${account.address}`);

// Detect chainId from RPC
const publicClient = createPublicClient({
transport: http(rpcUrl),
});
const chainId = await publicClient.getChainId();

// Initialize API Kit
const apiKit = new SafeApiKit({
chainId: BigInt(chainId),
apiKey: safeApiKey,
});

// Initialize Protocol Kit
const protocolKit = await Safe.init({
provider: rpcUrl,
signer: safeProposerPrivateKey,
Expand All @@ -47,7 +42,6 @@ async function run() {

core.info(`👤 Safe initialized for: ${safeAddress}`);

// Create transaction
const safeTransactionData: MetaTransactionData = {
to: transactionTo,
value: transactionValue,
Expand All @@ -66,7 +60,6 @@ async function run() {

core.info(`🔐 Transaction signed - hash: ${safeTxHash}`);

// Propose transaction to the service
await apiKit.proposeTransaction({
safeAddress: safeAddress,
safeTransactionData: safeTransaction.data,
Expand All @@ -76,10 +69,8 @@ async function run() {
origin: "GitHub Action - Propose Safe Multisig Transaction",
});

// Get transaction details
const transaction = await apiKit.getTransaction(safeTxHash);

// Set outputs
core.setOutput("tx-hash", safeTxHash);
core.setOutput("tx-details", JSON.stringify(transaction));

Expand Down