Skip to content

Conversation

@jbern0rd
Copy link
Contributor

No description provided.

@jbern0rd jbern0rd self-assigned this Sep 24, 2025
@jbern0rd jbern0rd requested a review from Copilot September 24, 2025 09:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the EIP-712 implementation by introducing a new EIP712TypedData interface and applying it to iExec orders. The refactoring replaces the existing EIP712Entity approach with a cleaner interface-based design while maintaining backward compatibility through deprecation markers.

  • Introduces EIP712TypedData interface with simplified signing logic
  • Updates all order classes (AppOrder, DatasetOrder, RequestOrder, WorkerpoolOrder) to implement the new interface and include direct EIP-712 hash computation
  • Adds new signing methods to SignerService that work with the new interface

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/main/java/com/iexec/commons/poco/eip712/EIP712TypedData.java New interface defining EIP-712 typed data contract with hash computation and signing methods
src/main/java/com/iexec/commons/poco/eip712/EIP712Entity.java Deprecated existing EIP712Entity class
src/main/java/com/iexec/commons/poco/order/*.java Updated all order classes to implement EIP712TypedData with computeMessageHash methods
src/main/java/com/iexec/commons/poco/chain/SignerService.java Added new signing methods for EIP712TypedData interface
src/test/java/com/iexec/commons/poco/order/*Tests.java Added tests for new signing functionality
src/test/java/com/iexec/commons/poco/itest/OrdersService.java Updated to use new signing methods
src/test/resources/logback-test.xml Added debug logging for com.iexec package and removed license header

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jbern0rd jbern0rd requested a review from Copilot September 24, 2025 11:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jbern0rd jbern0rd requested a review from Copilot September 24, 2025 12:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@jbern0rd jbern0rd merged commit c07cf70 into main Sep 24, 2025
3 checks passed
@jbern0rd jbern0rd deleted the feature/refactor-iexec-orders branch September 24, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants