-
Notifications
You must be signed in to change notification settings - Fork 1
feat: refactor EIP-712 implementation with a new interface and applies it to iExec orders #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s it to iExec orders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the EIP-712 implementation by introducing a new EIP712TypedData interface and applying it to iExec orders. The refactoring replaces the existing EIP712Entity approach with a cleaner interface-based design while maintaining backward compatibility through deprecation markers.
- Introduces
EIP712TypedDatainterface with simplified signing logic - Updates all order classes (AppOrder, DatasetOrder, RequestOrder, WorkerpoolOrder) to implement the new interface and include direct EIP-712 hash computation
- Adds new signing methods to
SignerServicethat work with the new interface
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/iexec/commons/poco/eip712/EIP712TypedData.java | New interface defining EIP-712 typed data contract with hash computation and signing methods |
| src/main/java/com/iexec/commons/poco/eip712/EIP712Entity.java | Deprecated existing EIP712Entity class |
| src/main/java/com/iexec/commons/poco/order/*.java | Updated all order classes to implement EIP712TypedData with computeMessageHash methods |
| src/main/java/com/iexec/commons/poco/chain/SignerService.java | Added new signing methods for EIP712TypedData interface |
| src/test/java/com/iexec/commons/poco/order/*Tests.java | Added tests for new signing functionality |
| src/test/java/com/iexec/commons/poco/itest/OrdersService.java | Updated to use new signing methods |
| src/test/resources/logback-test.xml | Added debug logging for com.iexec package and removed license header |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/com/iexec/commons/poco/order/WorkerpoolOrder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/test/java/com/iexec/commons/poco/order/WorkerpoolOrderTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/iexec/commons/poco/order/RequestOrderTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/iexec/commons/poco/order/DatasetOrderTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|



No description provided.