feat: experimental networks #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreJeanjacquot
force-pushed
the
feat/experimental-networks
branch
from
15b96d0 to
24aa2b8
Compare
PierreJeanjacquot
force-pushed
the
feat/experimental-networks
branch
from
a5fc744 to
f4345b3
Compare
PierreJeanjacquot
force-pushed
the
feat/experimental-networks
branch
from
098bd47 to
85fe30f
Compare
Le-Caignec
reviewed
Jun 19, 2025
Comment on lines
76
to
87
| export const getId = (idOrName, { allowExperimentalNetworks = false } = {}) => | ||
| networkConfigs | ||
| .filter( | ||
| ({ isExperimental }) => | ||
| allowExperimentalNetworks || isExperimental === false, | ||
| ) | ||
| .find(({ id, name }) => idOrName === name || `${idOrName}` === `${id}`)?.id; | ||
|
|
||
| export const getChainDefaults = ( | ||
| id, | ||
| { allowExperimentalNetworks = false } = {}, | ||
| ) => { |
Contributor
There was a problem hiding this comment.
I have the feeling that these two functions could be merged into one. Would it be worth doing ?
Member
Author
There was a problem hiding this comment.
Honestly, the project being 7 years old and in plain JS, a refactor can be quite touchy, I'll not do this without a strong reason
Co-authored-by: Robin Le Caignec <[email protected]>
Le-Caignec
approved these changes
Jun 19, 2025
This was referenced Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Extended default configs with experimental networks default configs
By default, experimental networks are hidden but can be enabled by setting
"allowExperimentalNetworks": truechains.jsonfor the CLIIExecModules (lib)utils.getSignerFromPrivateKey(network, options)(lib)Added
arbitrum-sepolia-testnetas the first experimental networkMisc