Skip to content

Conversation

@PierreJeanjacquot
Copy link
Member

No description provided.

@github-actions
Copy link

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
Dockerfile:18 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:19 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`
Dockerfile:19 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Copy link
Contributor

@abbesBenayache abbesBenayache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi requested a review from Copilot July 15, 2025 10:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the documentation to reflect that getNetwork() now returns chainId as a string rather than a number.

  • Changed return type of getNetwork signature from number to string
  • Updated both the inline signature and the Returns section in the docs
Comments suppressed due to low confidence (2)

docs/classes/IExecNetworkModule.md:67

  • [nitpick] The markdown formatting escapes the '>' and splits the code into multiple spans, which can be hard to read. Consider wrapping the entire return type in a single code span, e.g., Promise<{ chainId: string; isNative: boolean }>, and remove the escape.
▸ **getNetwork**(): `Promise`<{ `chainId`: `string` ; `isNative`: `boolean`  }\>

docs/classes/IExecNetworkModule.md:81

  • [nitpick] Similarly for the Returns section, wrap the full signature in one code span: Promise<{ chainId: string; isNative: boolean }> and remove the unnecessary escape for '>.'
`Promise`<{ `chainId`: `string` ; `isNative`: `boolean`  }\>

@sonarqubecloud
Copy link

@PierreJeanjacquot PierreJeanjacquot merged commit 9c747d0 into master Jul 15, 2025
11 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the fix/getnetwork-return-type branch July 15, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants