fix: allow TEE datasetorders without framework #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
|
PierreJeanjacquot
force-pushed
the
feat/dataset-tee-agnostic-tag
branch
from
5341157 to
d04903f
Compare
PierreJeanjacquot
force-pushed
the
feat/dataset-tee-agnostic-tag
branch
from
d04903f to
2cb5b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datasets use standard encryption that makes them agnostic to the TEE framework as soon as their secret is present in the SMS.
Creating datasetorders without a specified TEE framework let the dataset owner to allow the dataset to be consumed in any TEE framework.
Current limitation: when datasetorder does not specify the TEE framework to use,
signDatasetorderandpublishDatasetorderperform a preflight to check the dataset secret is in the default SMS (scone). We may want to check whether the secret is present in all SMS or completely skip this check.