Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 13, 2025

This reverts commit b670d26.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b670d26). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?        4           
  Lines           ?      111           
  Branches        ?        7           
=======================================
  Hits            ?       93           
  Misses          ?       17           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Le-Caignec Le-Caignec self-requested a review October 13, 2025 09:15
@zguesmi zguesmi marked this pull request as ready for review October 13, 2025 10:38
Copilot AI review requested due to automatic review settings October 13, 2025 10:38
@zguesmi zguesmi self-assigned this Oct 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous commit that enabled artifact committing by reverting build configuration changes and removing committed build artifacts. The reversion returns the project to using the standard out directory for build outputs instead of a custom artifacts directory.

  • Reverts Foundry configuration from artifacts back to out directory
  • Removes committed build artifact JSON files
  • Removes CI workflow for verifying artifacts and related environment variables

Reviewed Changes

Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
foundry.toml Reverts output directory from "artifacts" back to "out"
slither.config.json Removes foundry_out_directory configuration
artifacts/*.json Removes committed build artifacts
.github/workflows/verify-artifacts.yml Removes artifact verification workflow
.github/workflows/main.yml Removes FOUNDRY_OUT environment variable and forge clean command
.github/workflows/deploy.yml Removes FOUNDRY_OUT environment variable
.env.template Removes FOUNDRY_OUT configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zguesmi zguesmi requested a review from gfournierPro October 13, 2025 10:38
@zguesmi zguesmi merged commit 03ba891 into main Oct 13, 2025
5 checks passed
@zguesmi zguesmi deleted the chore/revert-artifacts-committing branch October 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants