feat: make contracts upgradable #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns in deployment scripts
…nd adjust submodule paths
…ripts for UUPS proxy pattern
Le-Caignec
commented
May 19, 2025
src/RLCOFT.sol
Outdated
Comment on lines
54
to
60
| function owner() | ||
| public | ||
| view | ||
| override(OwnableUpgradeable, AccessControlDefaultAdminRulesUpgradeable) | ||
| returns (address) | ||
| { | ||
| return AccessControlDefaultAdminRulesUpgradeable.owner(); |
Member
There was a problem hiding this comment.
I think it's better to return the actual owner of the contract otherwise it can lead to errors.
zguesmi
reviewed
May 19, 2025
…oving outdated files and improving structure
…onment variables and script parameters
…rity in RLCAdapter and RLCOFT contracts
…d RLCOFT contracts
… is enabled in foundry.toml
…nd RLCOFT scripts
…r and RLCOFT deployment scripts
zguesmi
changed the title
…deployment in RLCAdapter and RLCOFT scripts
zguesmi
reviewed
May 21, 2025
src/RLCOFT.sol
Outdated
Comment on lines
54
to
60
| function owner() | ||
| public | ||
| view | ||
| override(OwnableUpgradeable, AccessControlDefaultAdminRulesUpgradeable) | ||
| returns (address) | ||
| { | ||
| return AccessControlDefaultAdminRulesUpgradeable.owner(); |
Member
There was a problem hiding this comment.
I think it's better to return the actual owner of the contract otherwise it can lead to errors.
…ment script for consistency
… to use OwnableUpgradeable
Contributor
Author
|
i fix to change and use owner from OwnableUpgradeable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.