feat: add unit tests for internal _debit function
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup in TestUtils
…hain functionality
…rZeroBridge _credit tests
…s-for-_mint-function
…/add-unit-tests-for-_debit-function
Le-Caignec
changed the title
_debit function #62
…-function' into feature/add-unit-tests-for-_debit-function
…or paused transfers
…/add-unit-tests-for-_debit-function
Le-Caignec
changed the title
_debit function #62_debit function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 4 4
Lines 111 111
Branches 7 7
=======================================
Hits 93 93
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
gfournierPro
reviewed
Jul 7, 2025
Base automatically changed from
feature/add-unit-tests-for-_mint-function
to
main
July 10, 2025 15:58
gfournierPro
approved these changes
Jul 15, 2025
zguesmi
reviewed
Jul 18, 2025
Member
zguesmi
left a comment
zguesmi
left a comment
There was a problem hiding this comment.
We need to test the slippage mechanism. Check that _debit reverts with SlippageExceeded when the slippage amount is exceeded.
… to remove dust from amounts
Contributor
Author
|
Added test for slippage exceedance : Commit: e9741ff |
zguesmi
reviewed
Jul 18, 2025
zguesmi
approved these changes
Jul 18, 2025
Co-authored-by: Zied Guesmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.