Skip to content

fix: configure send scripts #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfournierPro merged 9 commits into from
Jul 8, 2025
Merged

fix: configure send scripts #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
57fc26f
refactor: Update deployment scripts and configuration for cross-chain…
gfournierPro Jul 8, 2025
ee5648e
Merge branch 'main' into fix/configure-send-scripts
gfournierPro Jul 8, 2025
3afe933
fix: Remove unused extra options in cross-chain token transfer
gfournierPro Jul 8, 2025
f16222e
refactor: Update cross-chain token transfer options for improved gas …
gfournierPro Jul 8, 2025
4eaaf25
fix: Ensure broadcasting starts before executing cross-chain transfer
gfournierPro Jul 8, 2025
88c6148
refactor: Remove commented-out deploy commands and adjust verbosity f…
gfournierPro Jul 8, 2025
d047c26
refactor: Clean up commented-out code and adjust enforced options for…
gfournierPro Jul 8, 2025
a01dd2a
fix: Update enforced options for source bridge configuration to suppo…
gfournierPro Jul 8, 2025
0790644
Update script/bridges/layerZero/IexecLayerZeroBridge.s.sol
gfournierPro Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/SendFromArbitrumToEthereum.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ contract SendTokensFromArbitrumToEthereum is Script {
// Get the fee for the transfer
MessagingFee memory fee = iexecLayerZeroBridge.quoteSend(sendParam, false);
console.log("Fee amount: ", fee.nativeFee);

vm.startBroadcast();
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] After broadcasting, consider calling vm.stopBroadcast() once the send call completes to clearly delimit the broadcast session and prevent unintended subsequent transactions.

Copilot uses AI. Check for mistakes.
// Execute the cross-chain transfer
iexecLayerZeroBridge.send{value: fee.nativeFee}(sendParam, fee, msg.sender);

Expand Down
5 changes: 3 additions & 2 deletions script/bridges/layerZero/IexecLayerZeroBridge.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,10 @@ contract Configure is Script {
sourceBridge.setPeer(
targetParams.lzChainId, bytes32(uint256(uint160(targetParams.iexecLayerZeroBridgeAddress)))
);
EnforcedOptionParam[] memory enforcedOptions = new EnforcedOptionParam[](1);
EnforcedOptionParam[] memory enforcedOptions = new EnforcedOptionParam[](2);
bytes memory _extraOptions = OptionsBuilder.newOptions().addExecutorLzReceiveOption(70_000, 0); // 70_000 gas limit for the receiving executor and 0 for the executor's value
enforcedOptions[0] = EnforcedOptionParam(targetParams.lzChainId, 2, _extraOptions);
enforcedOptions[0] = EnforcedOptionParam(targetParams.lzChainId, 1, _extraOptions); // lzReceive
enforcedOptions[1] = EnforcedOptionParam(targetParams.lzChainId, 2, _extraOptions); // lzCompose
sourceBridge.setEnforcedOptions(enforcedOptions);
// Authorize bridge in the relevant contract.
if (sourceParams.approvalRequired) {
Expand Down