-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add deploy workflow for contract deployment #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… environment options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a dedicated GitHub Actions workflow for contract deployment, including input validation, network-specific deploy steps, artifact saving, and a placeholder for verification.
- Enhanced the main CI workflow to install Foundry with version pinning and caching
- Introduced
.github/workflows/deploy.ymlfor manual dispatch, environment validation, CI invocation, and multi-network deployments - Added steps to save deployment artifacts and a TODO for contract verification
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/main.yml | Specify version: stable and cache: true for Foundry install |
| .github/workflows/deploy.yml | New deploy workflow with inputs, validation, network-specific jobs |
Comments suppressed due to low confidence (5)
.github/workflows/deploy.yml:67
- GitHub Actions requires expressions in
ifto be wrapped with${{ }}. Change toif: ${{ inputs.network == 'anvil' }}to ensure the condition is evaluated.
if: inputs.network == 'anvil'
.github/workflows/deploy.yml:84
- Wrap the logical expression in
${{ }}so the condition is evaluated correctly, e.g.if: ${{ inputs.network == 'sepolia' || inputs.network == 'ethereum' }}.
if: inputs.network == 'sepolia' || inputs.network == 'ethereum'
.github/workflows/deploy.yml:94
- Ensure this
ifuses the GitHub Actions expression syntax:if: ${{ inputs.network == 'arbitrumSepolia' || inputs.network == 'arbitrum' }}.
if: inputs.network == 'arbitrumSepolia' || inputs.network == 'arbitrum'
.github/workflows/deploy.yml:75
- [nitpick] Using
&backgrounds commands and may not ensure both processes are ready; consider running sequentially or adding awaitto avoid race conditions.
make fork-sepolia & make fork-arbitrum-sepolia
.github/workflows/deploy.yml:78
- [nitpick] Fixed-duration sleeps can lead to flaky waits; consider polling the service endpoint or using a health-check loop instead of a static delay.
sleep 5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 4 4
Lines 111 111
Branches 7 7
=======================================
Hits 93 93
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…istency in CI workflows
…dant CI environment setting in workflow
… are set for coverage step
…cho in coverage step
…re environment is passed in deploy workflow
…roBridgeScript test
…nComputing/rlc-multichain into feature/deploy-ci
|
Concurrency issue
|
Co-authored-by: Zied Guesmi <[email protected]>
Co-authored-by: Zied Guesmi <[email protected]>
Co-authored-by: Zied Guesmi <[email protected]>
No description provided.