Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

No description provided.

@Le-Caignec Le-Caignec requested a review from Copilot July 16, 2025 13:33
@Le-Caignec Le-Caignec self-assigned this Jul 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a dedicated GitHub Actions workflow for contract deployment, including input validation, network-specific deploy steps, artifact saving, and a placeholder for verification.

  • Enhanced the main CI workflow to install Foundry with version pinning and caching
  • Introduced .github/workflows/deploy.yml for manual dispatch, environment validation, CI invocation, and multi-network deployments
  • Added steps to save deployment artifacts and a TODO for contract verification

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/main.yml Specify version: stable and cache: true for Foundry install
.github/workflows/deploy.yml New deploy workflow with inputs, validation, network-specific jobs
Comments suppressed due to low confidence (5)

.github/workflows/deploy.yml:67

  • GitHub Actions requires expressions in if to be wrapped with ${{ }}. Change to if: ${{ inputs.network == 'anvil' }} to ensure the condition is evaluated.
        if: inputs.network == 'anvil'

.github/workflows/deploy.yml:84

  • Wrap the logical expression in ${{ }} so the condition is evaluated correctly, e.g. if: ${{ inputs.network == 'sepolia' || inputs.network == 'ethereum' }}.
        if: inputs.network == 'sepolia' || inputs.network == 'ethereum'

.github/workflows/deploy.yml:94

  • Ensure this if uses the GitHub Actions expression syntax: if: ${{ inputs.network == 'arbitrumSepolia' || inputs.network == 'arbitrum' }}.
        if: inputs.network == 'arbitrumSepolia' || inputs.network == 'arbitrum'

.github/workflows/deploy.yml:75

  • [nitpick] Using & backgrounds commands and may not ensure both processes are ready; consider running sequentially or adding a wait to avoid race conditions.
          make fork-sepolia & make fork-arbitrum-sepolia

.github/workflows/deploy.yml:78

  • [nitpick] Fixed-duration sleeps can lead to flaky waits; consider polling the service endpoint or using a health-check loop instead of a static delay.
          sleep 5

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (8ccc0e4) to head (d8e9ed5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files           4        4           
  Lines         111      111           
  Branches        7        7           
=======================================
  Hits           93       93           
  Misses         17       17           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Le-Caignec Le-Caignec requested a review from zguesmi July 21, 2025 11:59
@Le-Caignec
Copy link
Contributor Author

Concurrency issue
Concurrent Deployments: When multiple deployment workflows run simultaneously (e.g., sepolia and arbitrum), both:

  • Start from the same Git commit
  • Make their own deployment artifact commits locally
  • Try to push to the same branch
  • The second one fails because the remote branch has moved forward
  • Missing Git Options: Your current git-auto-commit-action configuration doesn't have the options we discussed to handle this scenario.

@Le-Caignec Le-Caignec temporarily deployed to arbitrum_sepolia July 21, 2025 13:29 — with GitHub Actions Inactive
@Le-Caignec Le-Caignec merged commit 3c7288e into main Jul 21, 2025
4 checks passed
@Le-Caignec Le-Caignec deleted the feature/deploy-ci branch July 21, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants