feat: prepare mainnet #84

gfournierPro · 2025-07-30T06:38:40Z

No description provided.

…or Ethereum and Arbitrum mainnets

… workflow

…ameter

gfournierPro · 2025-07-30T06:48:37Z

script/SendFromArbitrumToEthereum.s.sol

 pragma solidity ^0.8.22;

 import {Script, console} from "forge-std/Script.sol";


No important change just cleaning

gfournierPro · 2025-07-30T06:48:43Z

script/SendFromEthereumToArbitrum.s.sol

 pragma solidity ^0.8.22;

 import {Script, console} from "forge-std/Script.sol";
+import {ConfigLib} from "./lib/ConfigLib.sol";
 import {IexecLayerZeroBridge} from "../src/bridges/layerZero/IexecLayerZeroBridge.sol";


No important change just cleaning

codecov · 2025-07-30T06:51:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4974fa7). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?        4           
  Lines           ?      111           
  Branches        ?        7           
=======================================
  Hits            ?       93           
  Misses          ?       17           
  Partials        ?        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env.template

zguesmi · 2025-07-30T08:56:39Z

.github/workflows/deploy.yml

+        env:
+          ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
+          SEPOLIA_RPC_URL: ${{ vars.SEPOLIA_RPC_URL }}
+          ARBITRUM_SEPOLIA_RPC_URL: ${{ vars.ARBITRUM_SEPOLIA_RPC_URL }}
+          ETHEREUM_RPC_URL: ${{ secrets.RPC_URL }}
+          ARBITRUM_RPC_URL: ${{ secrets.RPC_URL }}


This should be adapted to environment. secrets.RPC_URL will be sepolia not mainnet on certain Github envs.
We can use names like SOURCHAIN_CHAIN_RPC_URL and DESTINATION_CHAIN_RPC_URL

sry I don't get this comment

since we call make verify-all-${{ inputs.network }}
we need only one of 4 RPC to be sets

We can use names like SOURCHAIN_CHAIN_RPC_URL and DESTINATION_CHAIN_RPC_URL

Since we run this script 1 network per 1 , I don't see how to use that

Gonna check if I can put single RPC_URL on verification.mk

fix: simplify RPC URL handling in deployment and verification scripts
Made this

config/config.json

tools/verification.mk

…ions

… in .env.template

gfournierPro · 2025-07-30T14:18:43Z

To be merged after #12 or #85

Copilot

Pull Request Overview

This PR prepares the bridge system for mainnet deployment by adding support for Ethereum and Arbitrum mainnets alongside the existing testnet support. The changes include configuration updates, script modifications, verification targets, and documentation enhancements.

Added mainnet configuration for Ethereum and Arbitrum networks with proper chain IDs and endpoint addresses
Refactored verification system to use parameterized templates supporting both testnet and mainnet networks
Updated cross-chain transfer scripts with improved error handling, logging, and mainnet-specific functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/verification.mk	Refactored verification system to use parameterized templates for both testnet and mainnet networks
script/SendFromEthereumToArbitrum.s.sol	Enhanced transfer script with better logging, error handling, and mainnet support
script/SendFromArbitrumToEthereum.s.sol	Enhanced transfer script with improved structure and mainnet compatibility
config/config.json	Added mainnet network configurations with proper addresses and chain IDs
README.md	Updated documentation to reflect mainnet support and usage instructions
Makefile	Added mainnet transfer targets and cleaned up deployment options
.github/workflows/deploy.yml	Implemented contract verification in CI workflow
.env.template	Reorganized environment template with mainnet RPC URLs and better structure

Comments suppressed due to low confidence (2)

script/SendFromEthereumToArbitrum.s.sol:38

Using 'RECIPIENT_ADDRESS' environment variable for the sender is confusing. Consider renaming to 'SENDER_ADDRESS' or using a more descriptive variable name.

        address sender = vm.envAddress("RECIPIENT_ADDRESS");

script/SendFromArbitrumToEthereum.s.sol:42

Using 'RECIPIENT_ADDRESS' environment variable for the sender is confusing. Consider renaming to 'SENDER_ADDRESS' or using a more descriptive variable name.

        address sender = vm.envAddress("RECIPIENT_ADDRESS");

config/config.json

tools/verification.mk

.github/workflows/deploy.yml

Le-Caignec · 2025-07-31T11:53:29Z

config/config.json

+  "initialAdmin": "0x111165a109feca14e4ad4d805f6460c7d206ead1",
+  "initialUpgrader": "0x111121e2ec2557f484f65d5b1ad2b6b07b8acd23",
+  "initialPauser": "0x11113fe3513787f5a4f5f19690700e2736b3056e",


Could we add a TODO for that in the readme ?

what do you mean
todo for ?

Le-Caignec · 2025-07-31T11:58:06Z

script/SendFromArbitrumToEthereum.s.sol

Do we really need two scripts? Can’t we have a single contract script that handles the transfer in both directions?

we could yes
will make a todo

feat: add TODO for merging cross-chain token transfer scripts

gfournierPro added 7 commits July 29, 2025 17:10

feat: add configuration for Ethereum and Arbitrum chains in config.json

950e2f6

feat: enhance cross-chain transfer scripts and update configuration f…

6d1eda3

…or Ethereum and Arbitrum mainnets

feat: refactor verification targets for Ethereum and Arbitrum networks

6774976

feat: implement contract verification for multiple networks in deploy…

7ea4c73

… workflow

feat: update recipient address retrieval in cross-chain transfer scripts

3756bdd

feat: simplify deployment and upgrade targets by removing OPTIONS par…

111d3ef

…ameter

fix: forge fmt

4142ea8

gfournierPro self-assigned this Jul 30, 2025

gfournierPro commented Jul 30, 2025

View reviewed changes

zguesmi reviewed Jul 30, 2025

View reviewed changes

gfournierPro added 5 commits July 30, 2025 15:59

fix: update initial addresses in config.json

2492ff8

Merge branch 'main' into feature/prepare-mainnet

376ee66

fix: reset Createx salts to zero for Ethereum and Arbitrum configurat…

8e0487e

…ions

fix: clear default values for Etherscan API key and recipient address…

468ec90

… in .env.template

fix: update RPC URLs in .env.template to use Tenderly gateway

cbf938a

gfournierPro marked this pull request as ready for review July 30, 2025 14:17

gfournierPro requested review from Le-Caignec and Copilot July 30, 2025 14:17

This comment was marked as outdated.

Sign in to view

gfournierPro added 2 commits July 31, 2025 11:13

fix: simplify RPC URL handling in deployment and verification scripts

1463754

Merge branch 'main' into feature/prepare-mainnet

fbaa270

gfournierPro requested a review from Copilot July 31, 2025 09:17

Copilot AI reviewed Jul 31, 2025

View reviewed changes

config/config.json Show resolved Hide resolved

config/config.json Outdated Show resolved Hide resolved

tools/verification.mk Show resolved Hide resolved

Le-Caignec reviewed Jul 31, 2025

View reviewed changes

gfournierPro added 3 commits July 31, 2025 14:03

feat: add TODO for merging cross-chain token transfer scripts

02fee6b

fix: forge fmt

583fba5

feat: parametrize config.json for mainnet and testnet separation

a276c24

fix: allow contract verification step to continue on error

6359848

Le-Caignec approved these changes Jul 31, 2025

View reviewed changes

fix: update empty addresses in config.json for ethereum and arbitrum

61694ad

zguesmi approved these changes Jul 31, 2025

View reviewed changes

gfournierPro merged commit 67f1f54 into main Jul 31, 2025
4 of 5 checks passed

gfournierPro deleted the feature/prepare-mainnet branch July 31, 2025 13:25

iexec-release-please-app bot mentioned this pull request Jul 31, 2025

chore(main): release 0.1.0 #88

Merged

iexec-release-please-app bot mentioned this pull request Aug 14, 2025

chore(main): release 0.2.0 #100

Closed

		pragma solidity ^0.8.22;

		import {Script, console} from "forge-std/Script.sol";

feat: prepare mainnet #84

feat: prepare mainnet #84

Uh oh!

Conversation

gfournierPro commented Jul 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfournierPro Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfournierPro Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

gfournierPro commented Jul 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 30, 2025 •

edited

Loading

gfournierPro Jul 30, 2025 •

edited

Loading

gfournierPro Jul 31, 2025 •

edited

Loading