Merged
Conversation
…ent configuration
…y in RLCOFT contract
…nment variable for RPC URL in tests
…ridge role assignment
zguesmi
reviewed
May 23, 2025
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
zguesmi
reviewed
May 23, 2025
zguesmi
reviewed
May 23, 2025
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
…ockchainComputing/RLC-multichain into feature/pausable-minting
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
…plicate implementation
…ockchainComputing/RLC-multichain into feature/pausable-minting
…in RLCAdapter script
…izer details in foundry.toml
Le-Caignec
commented
Jun 2, 2025
test/units/RLCOFT.t.sol
Outdated
Comment on lines
46
to
47
| destAdapter = | ||
| RLCAdapterMock(new RLCAdapterDeploy().run(address(rlcToken), address(endpoints[DEST_EID]), owner, pauser)); |
Contributor
Author
There was a problem hiding this comment.
Instantiation is still required, as the wireOApps function called below checks that the contract at the given address conforms to the OFTAdapter interface before setting up the endpoints.
zguesmi
reviewed
Jun 2, 2025
gfournierPro
reviewed
Jun 3, 2025
gfournierPro
reviewed
Jun 3, 2025
gfournierPro
reviewed
Jun 3, 2025
gfournierPro
reviewed
Jun 3, 2025
gfournierPro
reviewed
Jun 3, 2025
gfournierPro
approved these changes
Jun 3, 2025
Contributor
gfournierPro
left a comment
gfournierPro
left a comment
There was a problem hiding this comment.
Huge work thanks for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.