feat: pause scripts #93
Conversation
… selection and dynamic matrix setup
…nctions in PauseBridgeScriptTest
There was a problem hiding this comment.
Pull Request Overview
Implements pause functionality for bridge operations with two-level pause system. Adds emergency pause scripts to halt bridge operations for security incidents, with Level 1 (complete pause) blocking all operations and Level 2 (outbound-only pause) allowing receives while blocking sends.
- Adds Makefile targets for pause/unpause operations on single chains
- Creates Solidity scripts for bridge pause management with validation
- Implements comprehensive test coverage for all pause scenarios and access controls
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pauser.mk | Defines Makefile targets for pause operations with CI/local environment handling |
| script/PauseBridge.s.sol | Core pause scripts implementing two-level pause system with validation |
| test/units/PauseBridgeScript.t.sol | Complete test suite covering pause operations, authorization, and edge cases |
| Makefile | Includes the new pauser.mk file |
| .github/workflows/bridge-pause-operations.yml | GitHub Actions workflow for automated pause operations |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage ? 83.78%
=======================================
Files ? 4
Lines ? 111
Branches ? 7
=======================================
Hits ? 93
Misses ? 17
Partials ? 1 ☔ View full report in Codecov by Sentry. |
…ons in PauseBridgeScriptTest
…havior during pause
Le-Caignec
left a comment
Le-Caignec
left a comment
There was a problem hiding this comment.
It could be nice to add a step in the default CI to check that these scripts always work, so we don’t break anything while developing new feature
test/units/PauseBridgeScript.t.sol
Outdated
| vm.stopPrank(); | ||
| } | ||
|
|
||
| // ====== Role and Authorization Tests ====== |
There was a problem hiding this comment.
I think the role and authorization tests here are unnecessary. The goal of this file is to ensure that the deployment script works properly, not to verify that the pause functionality has been implemented correctly. Moreover, this is already covered in another unit test file. What do you think?
There was a problem hiding this comment.
*execution script, not the deployment script
but yes will remove this part
it's tested in
|
No description provided.