-
Notifications
You must be signed in to change notification settings - Fork 1
ci: restore multi-package config and fix release-please #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SeddikBellamine
merged 7 commits into
main
from
fix/release-please-multi-package-config
Jul 16, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a82b2be
ci: restore multi-package config
SeddikBellamine 6601785
ci: add exclude-paths to prevent cross-package triggers
SeddikBellamine 716d268
ci: update package versions to alpha.0 and fix release-please config
SeddikBellamine e2f523c
ci: expand exclude-paths
SeddikBellamine 9a6145f
ci: update package versions and add release-please versioning guide
SeddikBellamine c41a28f
docs: update package versions in release-please guide
SeddikBellamine 86a0197
ci: update all packages to version 0.1.0-alpha.0
SeddikBellamine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| ".": "0.0.3-alpha" | ||
| } | ||
| ".": "0.1.0-alpha.0", | ||
| "dapp": "0.1.0-alpha.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| # Release-Please Versioning Guide | ||
|
|
||
| ## Important: When to Remove `versioning: 'prerelease'` | ||
|
|
||
| ### Current State (Prerelease Versions) - WORKING FINE | ||
|
|
||
| When your packages are using **prerelease versions** (like `0.0.3-alpha.0`, `0.1.0-beta.1`, etc.), the `versioning: 'prerelease'` field **CAN BE USED** and is working correctly. | ||
|
|
||
| **✅ CURRENT CONFIG (Working):** | ||
|
|
||
| ```json | ||
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "node", | ||
| "prerelease": true, | ||
| "prerelease-type": "alpha", | ||
| "versioning": "prerelease" // ← This is working fine for prereleases | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### When to Remove `versioning: 'prerelease'` | ||
|
|
||
| The `versioning: 'prerelease'` field should be **REMOVED** when: | ||
|
|
||
| 1. **Transitioning to stable versions** (like `1.0.0`, `2.1.0`) | ||
| 2. **Moving away from prerelease mode** | ||
| 3. **Starting a new stable release cycle** | ||
|
|
||
| **❌ INCORRECT for stable versions:** | ||
|
|
||
| ```json | ||
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "node", | ||
| "versioning": "prerelease" // ← REMOVE THIS for stable versions | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| **✅ CORRECT for stable versions:** | ||
|
|
||
| ```json | ||
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "node" | ||
| // No versioning field needed for stable versions | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Migration Path | ||
|
|
||
| #### Step 1: Current (Prerelease) - WORKING | ||
|
|
||
| ```json | ||
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "node", | ||
| "prerelease": true, | ||
| "prerelease-type": "alpha", | ||
| "versioning": "prerelease" // ← Keep this for prereleases | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| #### Step 2: When reaching stable version (1.0.0) - REMOVE | ||
|
|
||
| ```json | ||
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "node" | ||
| // Remove versioning field for stable versions | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Current Configuration (Prerelease Versions) | ||
|
|
||
| Since your packages are currently at: | ||
|
|
||
| - Main package: `0.1.0-alpha.0` | ||
| - Dapp package: `0.1.0-alpha.0` | ||
|
|
||
| ### Summary | ||
|
|
||
| | Package Version | Config Field | Action | | ||
| | --------------- | -------------------------- | --------------------- | | ||
| | `0.1.0-alpha.0` | `versioning: 'prerelease'` | ✅ **KEEP** (working) | | ||
| | `1.0.0` | `versioning: 'prerelease'` | ❌ **REMOVE** | | ||
|
|
||
| **Remember**: The `versioning` field works fine for prereleases but should be removed when transitioning to stable versions! |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.