feat: dapp address resolution from compass #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreJeanjacquot
requested review from
SeddikBellamine,
abbesBenayache and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR implements dapp address resolution from Compass service as a fallback mechanism when ENS is not supported on a network. The change allows the SDK to dynamically resolve dapp addresses from the Compass API when static configuration is unavailable.
- Adds a new utility function to fetch dapp addresses from Compass API endpoints
- Updates the SDK initialization to use Compass resolution as a fallback when dapp address is not configured
- Modifies chain configuration to mark ENS-unsupported networks with undefined dapp addresses
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/resolveDappAddressFromCompass.ts | New utility function to fetch dapp addresses from Compass API with error handling |
| src/web3telegram/IExecWeb3telegram.ts | Integrates Compass resolution into SDK initialization flow as fallback mechanism |
| src/config/config.ts | Updates Arbitrum Sepolia config to use undefined dapp address since ENS is not supported |
| tests/unit/utils/resolveDappAddressFromCompass.test.ts | Unit tests for the new Compass resolution utility function |
| tests/e2e/constructor.test.ts | E2E tests validating Compass-based address resolution in constructor |
| package.json | Updates iexec dependency to version 8.17.0 |
Comments suppressed due to low confidence (2)
tests/unit/utils/resolveDappAddressFromCompass.test.ts:17
- This test relies on an external network call to an invalid URL. Consider mocking the fetch call to make the test more reliable and faster.
it('should throw CompassCallError on network error', async () => {
tests/unit/utils/resolveDappAddressFromCompass.test.ts:10
- This test makes a real HTTP request to an external service. Consider mocking the fetch call to avoid dependency on external services and improve test reliability.
it('should resolve dapp address from a valid compass instance', async () => {
| ); | ||
| } | ||
| const contentType = response.headers.get('Content-Type'); | ||
| if (!contentType || contentType.indexOf('application/json') === -1) { |
There was a problem hiding this comment.
[nitpick] Use includes() method instead of indexOf() for better readability and modern JavaScript practices.
Suggested change
| if (!contentType || contentType.indexOf('application/json') === -1) { | |
| if (!contentType || !contentType.includes('application/json')) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.