Extended solver info structure #129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
| obj.info.conic.size_A = size(obj.args_in.a); | ||
| obj.info.conic.n_decVar = length(obj.args_in.x0); | ||
| % fill info struct | ||
| obj.solver_info.name = 'mosek'; |
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
| properties (Access=private) | ||
| solver; | ||
|
|
||
| sdp_info; |
Contributor
There was a problem hiding this comment.
please rename to sdpsol_info
tcunis
reviewed
Nov 19, 2025
| ); | ||
|
|
||
| % number of decision variables | ||
| obj.sdp_info.n_decVar = numel(x); |
Contributor
There was a problem hiding this comment.
please rename to numel_x. We should also add a field numel_g at least.
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
tcunis
reviewed
Nov 19, 2025
| % function to retrieve Gram solution with dimensions | ||
| obj.sdp2gram = casadi.Function('G', ... | ||
| {sdp.x}, {Qvar_G Ksdp_x_s Qcon_G Ksdp_g_s}, ... | ||
| {'x_sol'}, {'Qx', 'Qx_dim' 'Qc', 'Qc_dim'}); |
Contributor
There was a problem hiding this comment.
remove for now -- we'll get back to this in #95
…ver-specific information
…of gram matrices to buildproblem
Contributor
|
Hello @Fabian-Geyer, thank you for your changes. Could you please let me know about the status of this PR? If I should provide another review, please publish the PR again (it's currently in draft). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the info struct available for different solvers. The information is currently implemented in recursive fashion:
E.g. if
Sis asossolsolver, we can access information about problem sizes and sparsity as follows:Currently only the following solvers are implemented:
sossolsdpsolconicsolver specific(mosek, sedumi and clarabel - info structs not finished yet)Note:
infoonly holds information that is available during thebuildproblemstage. It is not supposed to hold information regarding solver status (S.statsshould be used for that)For this reason, at the solver level, the properties in
conicare split into two properties:ConicSolver.solver_info;ConicSolver.statusFinally, as mentioned above, the info struct now also hold information regarding the gram matrix.
Status: WIP