Open
Conversation
* better support for podman
+ up/down/ps/logs + also support for podman-compose + make run/stop should match run/stop.sh
Make it happen
Make it happen
Optimized Dockerfile for rebuild reuse of cache
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
Dockerfile,Makefile, andREADME.mdfiles, as well as the removal of therun.shandstop.shscripts. The changes aim to streamline the setup process, improve documentation, and enhance the Docker configuration.Docker and Makefile updates:
Dockerfile: Updated to usedocker.io/library/python:3.9-slimand reorganized the commands for better readability.Makefile: Introduced new variables and commands to manage Docker Compose operations, replacing the need forrun.shandstop.shscripts.docker-compose.yml: Modified to use environment variables for ports and hostname, improving flexibility and configurability.Documentation improvements:
README.md: Enhanced instructions for local setup, including steps to generate a.envfile and usemakecommands instead of shell scripts. Added clarity on environment variables and updated API endpoint descriptions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Removal of obsolete scripts:
run.shandstop.sh: These scripts were removed in favor of the newMakefilecommands, simplifying the process of running and stopping the application. [1] [2]