Skip to content

Conversation

@tetienne
Copy link
Collaborator

@tetienne tetienne commented Jan 9, 2026

Summary

  • Use sets for key membership checks (O(1) lookup vs O(n) for lists)
  • Simplify list iteration in obfuscate_sensitive_data by checking for dict directly instead of excluding other types
  • Remove obsolete pylint disable comment
  • Use tuple for value membership check since values can be unhashable types

Test plan

  • Existing tests pass
  • Pre-commit checks pass

- Use tuple instead of set for value membership since values can be
  unhashable types (list, dict)
- Revert obfuscate_string type signature to str only
@tetienne tetienne marked this pull request as ready for review January 9, 2026 09:10
@tetienne tetienne requested a review from iMicknl as a code owner January 9, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants