[Enhancement] NavigationViewItem #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
possible fix for #138 ? |
Contributor
|
Hi, it looks good for me and there is still one thing we can improve: the navigation group item should be expanded if its children item is selected. UI.WPF: 2025-07-03.12-37-18.mp4Here, Basic Input item is not expanded. WinUI3: 2025-07-03.12-36-56.mp4Here, Basic Input item is expanded. |
navigationviewitem handle pane open/ collapse
Contributor
Author
|
Please @Jack251970, can u take a look now ? |
Contributor
Now it works as expected. Good work!👍 |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #83
fix #138
navigationview item button no longer changes selection.
pane collapse/expand retains selected item.
fix:
NavViewItemButton.mp4
winui gallery:
winuiNavViewItem.mp4