Skip to content

[Style] CommandBarFlyout #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mou-haz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Style] CommandBarFlyout #276

mou-haz wants to merge 2 commits into from

Conversation

@mou-haz
Copy link
Contributor

@mou-haz mou-haz commented Jul 1, 2025

fix #265

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 1, 2025

Hey @GID0317 , can u take a look at this ?

@GID0317
Copy link
Contributor

GID0317 commented Jul 1, 2025

Hi, i can't compile the project for testing. the build is failing with MSB3030 because MSBuild is looking for satellite .resources.dll files for cultures like az-Latn-AZ, de-DE, ja-JP, etc

@mou-haz mou-haz force-pushed the fix_141_CommandBarFlyout_icon_defaultbehavior branch from a506a41 to 517d64f Compare July 1, 2025 15:18
@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 1, 2025

@GID0317 , i am not sure why you are getting this error, it builds fine on my end,

anyway, can u try again now ?

@mou-haz mou-haz marked this pull request as ready for review July 1, 2025 15:21
NotYoojun
NotYoojun requested changes Jul 2, 2025
View reviewed changes
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The padding is weired isn't it? Also the closing transition is looking strange:

Animation

@GID0317
Copy link
Contributor

GID0317 commented Jul 2, 2025

@GID0317 , i am not sure why you are getting this error, it builds fine on my end,

anyway, can u try again now ?

Still same sadly, it's regarding the satellite resources. it's shown like missing res languages and only effect this one. so, I can't test this one sorry.

the error like this keep happens. since i build manually using cli:

C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\az-Latn-AZ\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\bs-Latn-BA\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Cyrl-RS\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Cyrl-BA\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\sr-Latn-RS\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\uz-Latn-UZ\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\ha-Latn-NG\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\zh-Hans\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.
    C:\Program Files\dotnet\sdk\10.0.100-preview.5.25277.114\Microsoft.Common.CurrentVersion.targets(5005,5): error MSB3030: Could not copy the file "obj\Debug\net452\zh-Hant\iNKORE.UI.WPF.Modern.Controls.resources.dll" because it was not found.

But looking at NotYoojun reply the WinUI3 doesn't use old UWP context menu animation again which current used:

Screen.Recording.2025-07-02.120714.mp4

it should be like in WinUI:

Screen.Recording.2025-07-02.121330.mp4

@mou-haz mou-haz marked this pull request as draft July 2, 2025 23:21
@Jack251970
Copy link
Contributor

Jack251970 commented Jul 3, 2025

Some issues pop up for latest commits:

image

@mou-haz mou-haz force-pushed the fix_141_CommandBarFlyout_icon_defaultbehavior branch from f4c4357 to ac5958c Compare July 3, 2025 18:09
@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 3, 2025

it should work fine now,
but still trying to fix the close animation .

@Jack251970
Copy link
Contributor

Jack251970 commented Jul 4, 2025

It works well for me now👍

@mou-haz
[Fix] Update CommandBarFlyou Style
68f1a56 
updated command bar flyout and appbar button style to be more like the winui counterparts

minor test

minor test
@mou-haz mou-haz force-pushed the fix_141_CommandBarFlyout_icon_defaultbehavior branch from ac5958c to 68f1a56 Compare July 4, 2025 14:53
@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 4, 2025

@Jack251970 @GID0317 @NotYoojun
I think it's like the winui now, can you take a look ?

@mou-haz mou-haz marked this pull request as ready for review July 4, 2025 14:54
@mou-haz mou-haz requested a review from NotYoojun July 4, 2025 14:54
@Jack251970
Copy link
Contributor

Jack251970 commented Jul 4, 2025 •
edited
Loading

@mou-haz It looks so gooood to me! Very fluent!

And I wonder if you can fix these two app icons?

image

Suggested changes:

<ui:AppBarButton
    Click="OnElementClicked"
    Label="Save"
    ToolTipService.ToolTip="Save">
    <ui:AppBarButton.Icon>
        <ui:FontIcon Icon="{x:Static ui:SegoeFluentIcons.Save}" />
    </ui:AppBarButton.Icon>

</ui:AppBarButton>
<ui:AppBarButton
    Click="OnElementClicked"
    Label="Delete"
    ToolTipService.ToolTip="Delete">
    <ui:AppBarButton.Icon>
        <ui:FontIcon Icon="{x:Static ui:SegoeFluentIcons.Delete}" />
    </ui:AppBarButton.Icon>

</ui:AppBarButton>

in CommandBarFlyoutPage.xaml

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 4, 2025

@Jack251970 done

@GID0317
Copy link
Contributor

GID0317 commented Jul 4, 2025

@Jack251970 @GID0317 @NotYoojun I think it's like the winui now, can you take a look ?

Hi,
Sorry as before look like I can't test for this one. the error keeps showing for this fix. but based on Jack251970 images its already look good like WinUI. Nice works!

@mou-haz mou-haz changed the title [Style] command bar flyout style update [Style] CommandBarFlyout Jul 11, 2025
@GID0317 GID0317 mentioned this pull request Jul 25, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotYoojun NotYoojun Awaiting requested review from NotYoojun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] CommandBarFlyout Style was not match the WinUI3 Style

4 participants

@mou-haz @GID0317 @Jack251970 @NotYoojun