Skip to content

Conversation

@GID0317
Copy link
Contributor

@GID0317 GID0317 commented Aug 28, 2025

image image

Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: Changes requested before we can merge

Thanks for your contribution! 🙌🏻

We've reviewed your pull request and it's a great step forward.
Before we can merge it, there are just a few things that would make it even better:

Add "Usage (XAML)" column after "Style"

Besides the "Style" column, add a "Usage (XAML)" column with copy buttons, just like the Typography page, making it more convenient to get what users want.

Image Image

When you have a chance, please update the PR with these refinements.
If anything is unclear or you'd like guidance, we're more than happy to help - just let us know.

If you don't have the time or energy to make these changes yourself, that's completely okay.
But please always say so openly, let us know, and our team or other contributors can step in to help finish it up if anyone is available.

We truly appreciate the time and care you've already put into this.
If you have any objections, questions, or ideas, please reply below so we can work through them together.

@GID0317
Copy link
Contributor Author

GID0317 commented Sep 2, 2025

Hi, I think it's already done now:
image

@GID0317 GID0317 requested a review from NotYoojun September 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants