[FIX] NavigationView focus change using keyboard#371
Open
mou-haz wants to merge 1 commit intoiNKORE-NET:mainfrom
Open
[FIX] NavigationView focus change using keyboard#371mou-haz wants to merge 1 commit intoiNKORE-NET:mainfrom
mou-haz wants to merge 1 commit intoiNKORE-NET:mainfrom
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes keyboard event bubbling issues in the NavigationView control by implementing a mechanism to selectively prevent key events from bubbling up when they've been handled. The change addresses issues where ScrollViewer and AutoSuggestBox TextBox components were marking events as handled, preventing proper bubbling to KeyboardFocusManager.
Key changes:
- Added a class-level KeyDown event handler that resets event handled state based on a flag
- Introduced
NoNeedToBubbleKeyEventsflag to control when events should not bubble - Updated all focus navigation methods to set this flag when they successfully handle key events
- Removed fallback focus navigation logic from
FocusNextDownItemmethod
Comments suppressed due to low confidence (2)
source/iNKORE.UI.WPF.Modern.Controls/Controls/Windows/NavigationView/NavigationView.cs:3018
- The
FocusNextRightItemmethod is missing theNoNeedToBubbleKeyEventsflag assignment that was added to other focus navigation methods (FocusNextUpItemandFocusNextDownItem). Whenargs.Handledis set to true (whenMoveFocussucceeds), the flag should also be set to maintain consistent behavior across all focus navigation methods.
void FocusNextRightItem(NavigationViewItem nvi, KeyEventArgs args)
{
args.Handled = nvi.MoveFocus(new TraversalRequest(FocusNavigationDirection.Right));
}
source/iNKORE.UI.WPF.Modern.Controls/Controls/Windows/NavigationView/NavigationView.cs:2987
- Corrected spelling of 'otherise' to 'otherwise'.
// If item has focusable children, move focus to first focusable child, otherise just defer to default XYKeyboardFocus behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #358.