-
Notifications
You must be signed in to change notification settings - Fork 370
feat(mission-control): add local geo layers to map #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maintenance-9.x
Are you sure you want to change the base?
Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
|
Please take a look on this one as I saw that you had marked #2164 for 9.1 . A related question: Will this also go into master if it goes into maintenance-9.x branch or does that require a separate PR? |
Add functionality to mission-control tab so that users can either load or drag&drop Geo files (KML, GeoJSON, GPX) to the visualization of the map. Use open layers native layers functionality for the visualization.
|
@sensei-hacker kind reminder to take a look on this one :) |
No other PR needed. maintenance-9.x and maintenance-10.x are the two branches that get PRs, depending on which version the change should go in. master isn't really used, because when it was used people would get confused about what it was used for. 🙂 Then maintenance-9.x will be merged up to maintenance-10.x Right now, I'm looking at merging only fixes for a possible 9.0.1, with no new enhancements, only fixes. Speaking of branches, I see you did this work on your master branch. |

User description
Add functionality to mission-control tab so that users can either load or drag&drop Geo files (KML, GeoJSON, GPX) to the visualization of the map. Use open layers native layers functionality for the visualization.
This is based on the changes nicely contributed with in #2164, with some small changes for usability and clarity. This being a separate PR is mainly for simplicity due to the staleness of the previous one.
PR Type
New Feature
Description
Add drag-and-drop support for GEO files (KML, GeoJSON, GPX, IGC, TopoJSON)
Implement layer management UI with visibility toggle and delete functionality
Persist custom layers to electron store for session recovery
Display feature hover information on map with smooth opacity transitions
Add PlannerLayerControl button to map controls for layer management access
Diagram Walkthrough
File Walkthrough
mission_control.js
Layer management and GEO file support implementationtabs/mission_control.js
KML, IGC, TopoJSON)
updateLayerListUI(),saveLayerToDisk(),removeLayerFromDisk(),addGeoLayerToMap()PlannerLayerControlclass for map control button with layermanagement panel
creation
detection
mission_control.html
Layer management UI and feature info display elementstabs/mission_control.html
container
semi-transparent background
mission_planer.css
CSS styling for layer controls and feature info displaysrc/css/tabs/mission_planer.css
.mission-control-layerspositioning styles for new layer controlbutton
.geozone-settingspositioning to accommodate new layer control.layer-itemhover effect with background color transition#geo_infoopacity transition styling for smooth feature infodisplay
messages.json
Internationalization strings for layer management featurelocale/en/messages.json
layerManagementTitle,layerLoadGeoFile,layerDragDropHintlayerConfirmDelete,layerLoadError,layerParseError