Fix firmware flasher board matching for multi-underscore targets

[sensei-hacker]

User description

Summary

Fixes firmware flasher board selection for targets with multiple underscores in their names (e.g., TBS_LUCID_H7_WING).

Problem

The original code only replaced the first underscore with a space when creating display names, which caused a mismatch:

• Dictionary was keyed by: "TBS LUCID_H7_WING" (first underscore → space)
• Lookup used: "TBS_LUCID_H7_WING" (all underscores)
• Result: Board not found in releases dictionary

Solution

1. Added normalizeTargetName() function to convert hyphens to underscores for consistent matching
2. Fixed parseFilename() and parseDevFilename() to replace ALL underscores/hyphens with spaces for display (using /g flag)
3. Changed releases dictionary to be keyed by normalized raw_target instead of modified target
4. Normalized all dictionary lookups to use consistent underscore format
5. Added support for hyphen-based filenames as a workaround (e.g., TBS-LUCID-H7-WING)

Changes

• tabs/firmware_flasher.js:
  • Add normalizeTargetName() function
  • Update parseFilename() to replace all underscores/hyphens
  • Update parseDevFilename() to replace all underscores/hyphens and accept hyphens in regex
  • Key releases dictionary by normalized targets
  • Normalize all lookups in board selection and FC auto-detect

Test Plan

• Manual testing with INAV Configurator dev build
• Verified board dropdown populates correctly
• Verified no console errors
• Confirmed fix handles both underscore and hyphen variants

Compatibility

• Backwards compatible: Works with existing underscore-based filenames
• Forward compatible: Also supports hyphen-based filenames as workaround

---

PR Type

Bug fix

---

Description

• Add normalizeTargetName() function to convert hyphens to underscores

• Fix board matching for multi-underscore target names like TBS_LUCID_H7_WING

• Replace all underscores/hyphens with spaces in display names using /g flag

• Normalize all dictionary lookups and board selection logic consistently

---

Diagram Walkthrough

flowchart LR
  A["Target Name<br/>TBS_LUCID_H7_WING"] --> B["normalizeTargetName()"]
  B --> C["Normalized<br/>TBS_LUCID_H7_WING"]
  C --> D["Dictionary Key<br/>Lookup"]
  D --> E["Board Found<br/>& Selected"]
  F["parseFilename()"] --> G["Replace All<br/>Underscores/Hyphens"]
  G --> H["Display Name<br/>TBS LUCID H7 WING"]

Loading

File Walkthrough

Relevant files

Bug fix

firmware_flasher.js Normalize target names for consistent board matching          tabs/firmware_flasher.js Added normalizeTargetName() function to convert hyphens to underscores for consistent matching Updated parseFilename() and parseDevFilename() to replace all underscores/hyphens with spaces using /g flag Modified regex in parseDevFilename() to accept hyphens in target names ([A-Za-z0-9_-]+) Changed all releases dictionary keys and lookups to use normalized raw_target instead of modified target Normalized board selection and FC auto-detect logic to use consistent underscore format +30/-14

---

[github-actions]

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

• maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

• maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.

---

This is an automated suggestion to help route contributions to the appropriate branch.

[qodo-code-review]

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

[qodo-code-review]

Suggestion: normalizeTargetName() assumes name is always a string, but new call sites pass values that can be 0, undefined, or non-strings; coerce/guard before using .replace() so the UI doesn’t crash on unexpected values. [Learned best practice, importance: 6]

Suggested change

	function normalizeTargetName(name) {
	return name.replace(/-/g, '_');
	}
	function normalizeTargetName(name) {
	if (name == null) return '';
	return String(name).replace(/-/g, '_');
	}