OSD elements i18n #2524
Open
OSD elements i18n #2524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+3674
to
+3676
| "osdElement_MISSION INFO": { | ||
| "message": "Mission Info" | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggestion: Replace the space with an underscore in the osdElement_MISSION INFO key to follow naming conventions and prevent potential lookup errors. [general, importance: 7]
Suggested change
| "osdElement_MISSION INFO": { | |
| "message": "Mission Info" | |
| }, | |
| "osdElement_MISSION_INFO": { | |
| "message": "Mission Info" | |
| } |
Comment on lines
6390
to
6392
| "osdElement_DISTANCE_TO_HOME": { | ||
| "message": "Направление домой" | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggestion: Correct the Russian translation for osdElement_DISTANCE_TO_HOME to "Расстояние до дома" to accurately mean "Distance to Home". [possible issue, importance: 8]
Suggested change
| "osdElement_DISTANCE_TO_HOME": { | |
| "message": "Направление домой" | |
| }, | |
| "osdElement_DISTANCE_TO_HOME": { | |
| "message": "Расстояние до дома" | |
| } |
Comment on lines
3623
to
+3646
| "osd_pilot_name": { | ||
| "message": "Pilot's Name" | ||
| }, | ||
| "osdElement_POWER_SUPPLY_IMPEDANCE": { | ||
| "message": "Power Supply Impedance" | ||
| }, | ||
| "osdElement_REMAINING_FLIGHT_TIME": { | ||
| "message": "Remaining Flight Time" | ||
| }, | ||
| "osdElement_REMAINING_FLIGHT_DISTANCE": { | ||
| "message": "Remaining Flight Distance" | ||
| }, | ||
| "osdElement_THROTTLE_GAUGE": { | ||
| "message": "Throttle Gauge" | ||
| }, | ||
| "osdElement_THROTTLE_POSITION": { | ||
| "message": "Throttle Position" | ||
| }, | ||
| "osdElement_SCALED_THROTTLE_POSITION": { | ||
| "message": "Scaled Throttle Position" | ||
| }, | ||
| "osdElement_CRAFT_NAME": { | ||
| "message": "Craft Name" | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggestion: Remove the duplicate osd_craft_name translation entry and standardize on using osdElement_CRAFT_NAME to avoid inconsistency. [general, importance: 6]
New proposed code:
-"osd_craft_name": {
- "message": "Craft Name"
-},
"osdElement_CRAFT_NAME": {
"message": "Craft Name"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Added en osd elements string (for simplify track in tools like weblate, pontoon, poeditor and other), extracted from osd.js, i18n keys creates here.
Added ru translations of new elements.
PR Type
Enhancement
Description
Added 47 English OSD element translations for internationalization
Added 47 Russian OSD element translations with localized descriptions
Fixed HTML tag syntax error in Russian FrSky fuel unit help text
Diagram Walkthrough
File Walkthrough
messages.json
Added 47 English OSD element translationslocale/en/messages.json
elements
throttle, heading, altitude, and various configuration parameters
messages.json
Added 47 Russian OSD translations and fixed HTML taglocale/ru/messages.json
settings
serialrx_frSkyFuelUnitHelp(changed«топливо»to«топливо»)