correcting vspeed defaults in presets

[b14ckyy]

User description

With 9.0 the default presets have been missed updating for the vspeed controller values. Since the firmware defaults also have not been updated, a fresh plane setup or a setup with unchanged vspeed PIDFF controller values (not in diff) will have a 5x higher d value than recommended. This still results in dolphining on some platforms.

Updating the presets for the maintenance release that is planned.

---

PR Type

Bug fix

---

Description

• Corrected VSpeed PIDFF controller default parameters for firmware 9.0

• Removed outdated pre-9.0 vertical speed control values

• Added proper altitude control response and feedforward settings

• Updated parameters for FW-WT and other fixed-wing platforms

---

Diagram Walkthrough

flowchart LR
  A["Old VSpeed Parameters<br/>nav_fw_pos_z_p/i/d"] -->|Remove| B["Outdated Pre-9.0 Values"]
  C["New VSpeed Parameters<br/>set nav_fw_pos_z_p/i/d/FF<br/>set nav_fw_alt_control_response"] -->|Add| D["Firmware 9.0 Compliant"]
  B --> E["Prevent Dolphining<br/>on Fixed-Wing Platforms"]
  D --> E

Loading

File Walkthrough

Relevant files

Bug fix

defaults_dialog_entries.js Update VSpeed PIDFF defaults to firmware 9.0                          js/defaults_dialog_entries.js Removed outdated nav_fw_pos_z_p, nav_fw_pos_z_i, and nav_fw_pos_z_d parameters from FW-WT and other presets Added corrected VSpeed PIDFF parameters with set prefix: nav_fw_pos_z_p, nav_fw_pos_z_i, nav_fw_pos_z_d, and nav_fw_pos_z_FF Added nav_fw_alt_control_response parameter set to 45 for altitude control Updated parameter values to firmware 9.0 recommended settings for multiple fixed-wing presets +40/-24

---

[qodo-code-review]

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.