Skip to content

Conversation

@b14ckyy
Copy link
Collaborator

@b14ckyy b14ckyy commented Jan 25, 2026

User description

oopsie


PR Type

Enhancement


Description

  • Remove 'set' prefix from nav_fw_pos_z PID parameter keys

  • Standardize key naming convention across firmware defaults

  • Update 8 parameter entries in two profile configurations


Diagram Walkthrough

flowchart LR
  A["nav_fw_pos_z parameters<br/>with 'set' prefix"] -- "Remove prefix" --> B["Standardized parameter<br/>key names"]
Loading

File Walkthrough

Relevant files
Configuration changes
defaults_dialog_entries.js
Remove 'set' prefix from nav_fw_pos_z keys                             

js/defaults_dialog_entries.js

  • Removed 'set ' prefix from 4 nav_fw_pos_z PID parameter keys:
    nav_fw_pos_z_p, nav_fw_pos_z_i, nav_fw_pos_z_d, nav_fw_pos_z_FF
  • Changes applied in two separate profile sections (lines 517-530 and
    731-744)
  • Total of 8 key entries updated across both profiles
+8/-8     

@qodo-code-review
Copy link
Contributor

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Jan 25, 2026

Tested and works fine this time :)

@b14ckyy b14ckyy merged commit d7a1e84 into iNavFlight:maintenance-9.x Jan 25, 2026
6 checks passed
@glennvenghaus
Copy link

glennvenghaus commented Jan 26, 2026

You forgot this one
{
key: "set nav_fw_alt_control_response",
value: 45
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants