OSD: Make custom elements UI more intuitive#2560
Open
sensei-hacker wants to merge 5 commits intoiNavFlight:maintenance-9.xfrom
Open
OSD: Make custom elements UI more intuitive#2560sensei-hacker wants to merge 5 commits intoiNavFlight:maintenance-9.xfrom
sensei-hacker wants to merge 5 commits intoiNavFlight:maintenance-9.xfrom
Conversation
Replace the split two-panel layout (left: enable/position, right: slot config) with self-contained collapsible cards in the left panel. Each card has an enable toggle, preview text, and expand/collapse in the header, with slot configuration in the card body. Key changes: - Split the 28-option flat type dropdown into a 7-option source select (None, Text, Icon static/GV/LC, Global Variable, Logic Condition) plus a 12-option format select shown only for GV/LC sources - Progressive disclosure: configured cards expanded with blue border, first unconfigured expanded, rest collapsed - Hidden original type selects preserve save/load compatibility with existing fillCustomElementsValues() and customElementGetDataForRow() - Cards rebuild on every updateFields() call (layout switch, search) - Right panel custom element section hidden
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- Transpose table columns to stacked rows: each slot gets its own row
with [source select] [value input] side by side
- Visibility select gets its own row at bottom
- Replace table/tr/td structure with flexbox div rows (.ce-slot-row)
- Fix card header preview: generate plain-text summary instead of using
OSD font characters (FONT.symbol) which render as boxes in HTML
- Fix invisible inputs: add 'settings' class to card body for borders
- Update customElementsInitCallback to use card data-ce-index instead
of closest('tr').data('row') since table structure is removed
sensei-hacker
changed the title
Replace bare number input for Icon (static/GV/LC) with a clickable preview button that opens a popup grid of all 255 OSD font characters. User clicks a glyph tile to select it. The selected icon shows as an inline preview image with its character number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old: Four mystery boxes, each a flat list of 64 combinations of sources and formats:
Also with the old style you had to do the custom element in two places - setting it up on the right doesn't mean it'll appear.
New: six sources to choose from. Then separately, twelve formatting options:
While we're at it, instead of typing the number of an icon, 1 -256, this may be 784% better?