fix: sync JS programming framework constants with firmware#2577
Open
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Open
fix: sync JS programming framework constants with firmware#2577sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Conversation
- Add Angle Hold (mode 16) to flight mode operand types in classic programming tab (logicConditionOperantTypes.js). Firmware defines LOGIC_CONDITION_OPERAND_FLIGHT_MODE_ANGLEHOLD = 16 but it was missing from the UI, preventing users from selecting it as a flight mode operand. - Add OPERATION_NAMES[56] (Override Min Ground Speed) to inav_constants.js. OPERATION.OVERRIDE_MIN_GROUND_SPEED = 56 was present but the human-readable name was missing, causing 'unknown_operation_56' in warning messages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills two missing entries in the JavaScript programming framework lookup tables to match firmware definitions:
LOGIC_CONDITION_OPERAND_FLIGHT_MODE_ANGLEHOLD = 16but it was absent fromlogicConditionOperantTypes.js, so users could not select it as a flight mode operand in the Logic Conditions UI.OPERATION_NAMESininav_constants.js.OPERATION.OVERRIDE_MIN_GROUND_SPEED = 56was present but the human-readable name entry[56]was absent, causing'unknown_operation_56'in transpiler warning messages.Changes
js/logicConditionOperantTypes.js— Add16: "Angle Hold"to flight mode operand dictionaryjs/transpiler/transpiler/inav_constants.js— Add[56]: 'Override Min Ground Speed'toOPERATION_NAMESTesting
run_all_tests.cjs)inav.override.minGroundSpeeddecompiles correctly in the JS Programming tab (confirmed via screenshot)Code Review
Reviewed with inav-code-review agent — no critical or important issues found. Both numeric keys verified against firmware
logic_condition.h.Documentation
No documentation changes needed (bug fixes — missing UI entries).