Skip to content

PINIO: update configurator for unified PINIO/PWM output #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sensei-hacker wants to merge 75 commits into
base: maintenance-10.x
Choose a base branch
from

PINIO: fix operand order and add pwmOnPin() to JS transpiler

8819b67
Select commit
Loading
Failed to load commit list.
Draft

PINIO: update configurator for unified PINIO/PWM output #2579

PINIO: fix operand order and add pwmOnPin() to JS transpiler
8819b67
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 7, 2026 in 1m 29s

Quality Gate failed

Failed conditions
1 Security Hotspot
11.3% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 159 in js/transpiler/transpiler/codegen.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXRsfJpGf8FMujm7&open=AZzJRXRsfJpGf8FMujm7&pullRequest=2587

Check failure on line 83 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXeZfJpGf8FMujoC&open=AZzJRXeZfJpGf8FMujoC&pullRequest=2587

Check warning on line 38 in js/transpiler/transpiler/tests/utils/compare_original_vs_roundtrip.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXKefJpGf8FMujk8&open=AZzJRXKefJpGf8FMujk8&pullRequest=2587

Check warning on line 94 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXeZfJpGf8FMujoF&open=AZzJRXeZfJpGf8FMujoF&pullRequest=2587

Check failure on line 496 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnx&open=AZzJRXYrfJpGf8FMujnx&pullRequest=2587

Check warning on line 15 in js/transpiler/transpiler/tests/utils/functional_comparison.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXNqfJpGf8FMujlJ&open=AZzJRXNqfJpGf8FMujlJ&pullRequest=2587

Check warning on line 348 in js/transpiler/transpiler/parser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXRHfJpGf8FMujm5&open=AZzJRXRHfJpGf8FMujm5&pullRequest=2587

Check failure on line 1 in js/transpiler/transpiler/tests/utils/analyze_remaining_gap.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not import modules using an absolute path 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXOBfJpGf8FMujlk&open=AZzJRXOBfJpGf8FMujlk&pullRequest=2587

Check warning on line 104 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnU&open=AZzJRXYrfJpGf8FMujnU&pullRequest=2587

Check warning on line 40 in js/transpiler/transpiler/tests/roundtrip_vtol_transition.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXPSfJpGf8FMujmN&open=AZzJRXPSfJpGf8FMujmN&pullRequest=2587

Check warning on line 336 in index.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <div> tag. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXf8fJpGf8FMujoZ&open=AZzJRXf8fJpGf8FMujoZ&pullRequest=2587

Check warning on line 42 in js/transpiler/transpiler/tests/utils/functional_comparison.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXNqfJpGf8FMujlT&open=AZzJRXNqfJpGf8FMujlT&pullRequest=2587

Check warning on line 30 in js/transpiler/transpiler/tests/roundtrip_vtol_transition.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXPSfJpGf8FMujmL&open=AZzJRXPSfJpGf8FMujmL&pullRequest=2587

Check failure on line 190 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnp&open=AZzJRXYrfJpGf8FMujnp&pullRequest=2587

Check warning on line 115 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXeZfJpGf8FMujoI&open=AZzJRXeZfJpGf8FMujoI&pullRequest=2587

Check warning on line 3 in js/transpiler/transpiler/tests/utils/compare_original_vs_roundtrip.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:fs` over `fs`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXKefJpGf8FMujky&open=AZzJRXKefJpGf8FMujky&pullRequest=2587

Check warning on line 69 in js/transpiler/transpiler/action_decompiler.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`noOperandOperations` should be a `Set`, and use `noOperandOperations.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXSIfJpGf8FMujm-&open=AZzJRXSIfJpGf8FMujm-&pullRequest=2587

Check failure on line 803 in tabs/javascript_programming.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not assign `this` to `self`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXZPfJpGf8FMujn2&open=AZzJRXZPfJpGf8FMujn2&pullRequest=2587

Check warning on line 173 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnk&open=AZzJRXYrfJpGf8FMujnk&pullRequest=2587

Check warning on line 45 in js/transpiler/transpiler/tests/roundtrip_vtol_transition.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXPSfJpGf8FMujmS&open=AZzJRXPSfJpGf8FMujmS&pullRequest=2587

Check failure on line 42 in js/transpiler/transpiler/tests/run_all_tests.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXO1fJpGf8FMujl-&open=AZzJRXO1fJpGf8FMujl-&pullRequest=2587

Check failure on line 174 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnm&open=AZzJRXYrfJpGf8FMujnm&pullRequest=2587

Check warning on line 17 in js/transpiler/transpiler/tests/utils/functional_comparison.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXNqfJpGf8FMujlL&open=AZzJRXNqfJpGf8FMujlL&pullRequest=2587

Check failure on line 112 in tabs/firmware_flasher.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXeZfJpGf8FMujoH&open=AZzJRXeZfJpGf8FMujoH&pullRequest=2587

Check failure on line 478 in tabs/led_strip.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=iNavFlight_inav-configurator&issues=AZzJRXYrfJpGf8FMujnv&open=AZzJRXYrfJpGf8FMujnv&pullRequest=2587
View more details on SonarQubeCloud