Skip to content

FIX AT32 LED blink BUG #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunyanmeng963 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

FIX AT32 LED blink BUG #11228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/drivers/io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,11 @@ void IOToggle(IO_t io)
IO_GPIO(io)->BSRRL = mask;
}
#elif defined(AT32F43x)
if (IO_GPIO(io)->odt & mask)
mask <<= 16; // bit is set, shift mask to reset half

IO_GPIO(io)->scr = IO_Pin(io);
if (IO_GPIO(io)->odt & mask) {
IO_GPIO(io)->clr = mask;
} else {
IO_GPIO(io)->scr = mask;
}
Comment on lines +247 to +251
Copy link
Contributor

@qodo-code-review qodo-code-review bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Refactor the AT32F43x GPIO toggle logic to use the scr register for both setting and clearing pins in a single atomic write, which improves efficiency by removing the if/else branch. [general, importance: 6]

Suggested change
if (IO_GPIO(io)->odt & mask) {
IO_GPIO(io)->clr = mask;
} else {
IO_GPIO(io)->scr = mask;
}
#elif defined(AT32F43x)
uint32_t toggleMask = mask;
if (IO_GPIO(io)->odt & mask) {
toggleMask <<= 16;
}
IO_GPIO(io)->scr = toggleMask;

#else
if (IO_GPIO(io)->ODR & mask)
mask <<= 16; // bit is set, shift mask to reset half
Expand Down