-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MSP sync with IPF + poshold local targets #11230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maintenance-9.x
Are you sure you want to change the base?
Conversation
This reverts commit eec5481.
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
This is the part 2/3 of syncing MSP capabilities with IPF ops, pull is based on #11147
New Features:
These two mirror the IPF axis override and are only active when MSP RC OVERRIDE mode is active; require updating at 5HZ or they will clear, this ensures no lockout. This allows you to directly override and control the angle or rate in any mode via MSP.
These allow setting and reading directly the desired state in a sort of Local poshold control. So if you are in poshold, setting x_cm=100 will set the poshold target 1m to the front, y_cm=-50 will set the poshold target 50cm to your left, z_cm=-100 will set the althold target 1m lower. This allows nav-controlled pos control without using RC or geo coordinates, all using MSP.
This is the most uncertain as they mirror MSP_WP/MSP_SET_WP behavior directly for the poshold controller; i am insure about directly setting it vs using the waypoint control; but if one day there are significant changes it could be worthwhile to have dedicated MSP commands for target position, home, etc.
This is a convenient way to get directly the desired geo poshold or WP position at the same time as the target altitude, target heading and target climbrate
Fixes:
typedef enum name { … }) to avoid missing tagged definitions.Testing
Using HITL on SBF405WM with MLRS MSP RX; using https://github.com/xznhj8129/mspapi2/tree/refactor to test MSP commands and sequences.
All the commands were verified working in their intended configuration