Skip to content

Comments

refactor: remove dead applyPatchChanges after #926#928

Merged
IceyLiu merged 1 commit intomainfrom
fix/cleanup-dead-patch-apply-code
Feb 21, 2026
Merged

refactor: remove dead applyPatchChanges after #926#928
IceyLiu merged 1 commit intomainfrom
fix/cleanup-dead-patch-apply-code

Conversation

@piorpua
Copy link
Contributor

@piorpua piorpua commented Feb 21, 2026

Summary

  • Remove the now-unreachable applyPatchChanges method from CodexAgentManager
  • Remove the unused FileChange type import

After #926 made Codex CLI the single writer for apply_patch, both call sites of applyPatchChanges were removed. The method itself became dead code.

Test plan

  • Verify lint passes (npm run lint)
  • Verify no references to applyPatchChanges remain in CodexAgentManager.ts
  • Verify Codex agent patch approval flow still works (approval goes through confirm()respondElicitation() without local patch application)

PR #926 made Codex CLI the single writer for apply_patch,
removing the two call sites of applyPatchChanges. This removes
the now-unreachable method and its unused FileChange import.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

No issues found. The changes are clean and well-implemented.

@IceyLiu IceyLiu merged commit d0d0ade into main Feb 21, 2026
13 checks passed
@piorpua piorpua deleted the fix/cleanup-dead-patch-apply-code branch February 21, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants