feat(guid): agent bar select pop, spacing, assistant tag 1px border, add-assistant circle hover expand#940
feat(guid): agent bar select pop, spacing, assistant tag 1px border, add-assistant circle hover expand#940ringringlin wants to merge 2 commits intomainfrom
Conversation
…tant circle hover expand - Agent bar: agentSelectPop animation + agentItemSelected class on select - Assistant tags: explicit 1px border - Add assistant: circle with hover expand to pill (duration-500, max-w-320px) - Bottom quick actions: guidQuickActions class with safe-area-inset-bottom Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review
CRITICAL Issues
1. New console.log left in production code (violates debug hygiene rule)
File: src/renderer/pages/guid/index.tsx:~560-575
if (selectedAgent === 'gemini' && !currentEffectiveAgentInfo.isAvailable) {
console.log('[Guid] Gemini is not configured. Will check for alternatives when sending.');
}Problem: The project’s ESLint rules flag no-console (warn) and the review guidelines explicitly require flagging any new console.log added by the PR. This will ship to production and pollute logs.
Fix: Remove it, or replace with an app logger gated by environment (or downgrade to a user-facing Message.info if it’s actionable). For example:
if (selectedAgent === 'gemini' && !currentEffectiveAgentInfo.isAvailable) {
// optionally: Message.info(...) or do nothing
}MEDIUM Issues
2. CSS comment language doesn’t match project convention (English comments)
File: src/renderer/pages/guid/index.module.css:121-155
/* Agent 选中时:先放大再回落至略大(pop 动效) */
...
/* 底部快捷按钮:基础间距 + 安全区 */Description: Project conventions say “English code comments”. These new comments are Chinese, which makes the codebase inconsistent.
Recommendation/Fix: Translate to English, e.g.
/* Agent selected: pop animation (scale up then settle slightly larger) */
/* Bottom quick actions: base offset + safe area inset */Summary
| Level | Count |
|---|---|
| CRITICAL | 1 |
| HIGH | 0 |
| MEDIUM | 1 |
🤖 This review was generated by AI and may contain inaccuracies. Please focus on issues you agree with and feel free to disregard any that seem incorrect. Thank you for your contribution!
Note: The following inputs were truncated due to size limits: file contents (>80K chars).
Please review the omitted portions manually.
Description
Homepage (guid) UX polish on top of latest main:
agentSelectPopkeyframes (scale up to 1.12 then settle at 1.02) and.agentItemSelectedfor background and transition.gap: 4,maxWidth: 100%,padding: 6px,marginBottom: 20so the bar wraps nicely on small screens.borderWidth: 1pxfor consistency with the add-assistant dashed button..guidQuickActionswithbottom: calc(32px + env(safe-area-inset-bottom))to avoid overlap with safe area.Changes
src/renderer/pages/guid/index.module.css: Add@keyframes agentSelectPop,.agentItemSelected,.guidQuickActions.src/renderer/pages/guid/index.tsx: Agent bar container gap/maxWidth; selected item usesstyles.agentItemSelected; assistant tagsstyle={{ borderWidth: '1px' }}; add-assistant circle + hover expand; bottom bar usesstyles.guidQuickActions.Type of Change
Made with Cursor