Experiment with fs2-grpc aspect middleware #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typelevel/fs2-grpc#669
Seems to be working fine:
Here is the OpenTelemetry spec: https://opentelemetry.io/docs/specs/semconv/rpc/rpc-spans/#rpc-client-span
Right now, we can provide
rpc.system,rpc.method, andrpc.service.server.*andnetwork.*attributes can likely be provided as static attributes when creating a middleware.