Open
Conversation
Should be easier to maintain and internationalize
Impossible to maintain
iainbeeston
force-pushed
the
refactor_substitutions
branch
from
1e64871 to
e31ab28
Compare
block-based substitutions
Only works for days right now - construct interpreter needs fixing for that I think
iainbeeston
force-pushed
the
refactor_substitutions
branch
from
e31ab28 to
8871c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there are two problems with the code-base:
It's very difficult to find the right place to fix bugs
It's almost impossible to translate into other languages
I'm going to try to pull the substitutions that nickel does out into their own files, grouped by function. It's not going to fix the internationalisation problem (although it should be a good first step towards it), but it will make the code easier to maintain.