fix: CompletionsDataset mask_prompt passes wrong type to apply_chat_template#2
Open
fix: CompletionsDataset mask_prompt passes wrong type to apply_chat_template#2
Conversation
CompletionsDataset.process() passed messages[0] (a bare dict) to tokenizer.apply_chat_template() when mask_prompt=True, but the method expects a List[Dict]. Changed to messages[:1] (a list slice), matching the pattern already used by ChatDataset.process(). Added test coverage for mask_prompt=True and mask_prompt=False on both CompletionsDataset and ChatDataset. Closes #1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompletionsDataset.process()passing a bare dict (messages[0]) instead of a list (messages[:1]) totokenizer.apply_chat_template()whenmask_prompt=Truemask_prompt=Trueandmask_prompt=Falsepaths on bothCompletionsDatasetandChatDatasetCloses #1
Test plan
test_completions_mask_prompt-- verifiesmask_prompt=Trueproducesoffset > 0andmask_prompt=Falseproducesoffset == 0test_chat_mask_prompt-- regression guard for ChatDataset (already correct, now explicitly tested)Verification Evidence
datasets.py:119, tests cover both dataset types with bothmask_promptvalues🤖 Generated with Claude Code