Fix vector instatiation #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the ArduCopterApi::GetControlSignals method where the vector constructor was being used incorrectly. The old code attempted to use a float value as the size parameter for the vector constructor, which would create an empty or incorrectly-sized vector. The fix aligns the implementation with other controller APIs (MavLinkApi, ManualControllerApi, MatlabControllerApi, SimpleFlightApi) by using the two-parameter vector constructor to create a single-element vector containing the control output value.
Key changes:
- Fixed vector instantiation in
GetControlSignalsto usestd::vector<float>(1, value)instead ofstd::vector<float>(value) - Minor whitespace adjustment at end of file
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
About
This pull request makes a small change to the way control signals are returned in the
ArduCopterApi::GetControlSignalsmethod. Instead of copying the entire vector, it now returns a vector containing only a single control output value.ArduCopterApi::GetControlSignalsinarducopter_api.cppto return a vector with a single element (the mapped control output), rather than copying the entire vector.How Has This Been Tested?
Screenshots and videos (if appropriate):