This repository was archived by the owner on Sep 24, 2021. It is now read-only.
concurrent download using thread pool#407
Open
Fantoccini wants to merge 2 commits intoiambus:masterfrom
Fantoccini:master
Open
concurrent download using thread pool#407Fantoccini wants to merge 2 commits intoiambus:masterfrom Fantoccini:master
Fantoccini wants to merge 2 commits intoiambus:masterfrom
Fantoccini:master
Conversation
lixian_commands/download.py
Outdated
There was a problem hiding this comment.
Move the import line to the beginning of the file?
|
I prefer to have argument name as "concurrency" instead of "thread-number" to make it more clear for non-tech users. What does @iambus say? |
Contributor
|
What about |
Yeah I like that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on my raspberry pi