Skip to content

Temporary fix for CURLOPT_SSL_VERIFYPEER#32

Open
Niellles wants to merge 9 commits intoiamstuartwilson:masterfrom
Niellles:verifypeer-fix
Open

Temporary fix for CURLOPT_SSL_VERIFYPEER#32
Niellles wants to merge 9 commits intoiamstuartwilson:masterfrom
Niellles:verifypeer-fix

Conversation

@Niellles
Copy link
Contributor

@Niellles Niellles commented Jul 2, 2018

CURLOPT_SSL_VERIFYPEER shouldn't be set to false as this possibly weakens security.1 2

These fixes attempt to do the request with certificate verification and disable it if the request fails. Followed by a new curl attempt.

  1. Issue: Enable CURLOPT_SSL_VERIFYPEER option #18
  2. https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html

@Niellles Niellles changed the title CURLOPT_SSL_VERIFYPEER on StravaApi.php:129 is now set to (bool)true. Temporary fix for CURLOPT_SSL_VERIFYPEER Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant