This repository was archived by the owner on Mar 17, 2023. It is now read-only.
Add configurable aspect ratios#66
Open
thirstycoda wants to merge 7 commits intoiamutkarshtiwari:masterfrom
Open
Add configurable aspect ratios#66thirstycoda wants to merge 7 commits intoiamutkarshtiwari:masterfrom
thirstycoda wants to merge 7 commits intoiamutkarshtiwari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the ability to specify instagram aspect ratios in the crop feature, namely 4:5 and 1.91:1. This pull request allows you to override the default aspect ratios with your own set.
In addition to this, I want to display images edited with this library in a vertical scroll with the image filling the width of the screen. This will look weird if the photo is cropped to an aspect ratio of 1:10. Therefore, I have added the ability to set a minimum and maximum supported aspect ratio so you can allow free hand cropping but still protect your app from unusual aspect ratios
Apologies this change also includes the changes of my previous pull request (#65). I should have made a branch for those changes