This repository was archived by the owner on Mar 17, 2023. It is now read-only.
Move undo and redo buttons to toolbar#71
Open
thirstycoda wants to merge 8 commits intoiamutkarshtiwari:masterfrom
Open
Move undo and redo buttons to toolbar#71thirstycoda wants to merge 8 commits intoiamutkarshtiwari:masterfrom
thirstycoda wants to merge 8 commits intoiamutkarshtiwari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had feedback that the undo and redo buttons are a bit confusing. Some people thought part of the drawables had be cut off. Also when an image is a particular aspect ratio, the buttons appear on top of the image. In a busy image, these buttons aren't easy to see. Therefore I propose moving them up to the toolbar, next to the Done/Apply button